Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no inline links in stripe listen output when running in VS Code terminal #457

Closed
auchenberg-stripe opened this issue Jun 3, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@auchenberg-stripe
Copy link
Contributor

Issue

There's are no inline links in stripe listen output.

Expected Behavior

E.g. in iTerm, with working links:

image

No links in VSCode terminal:

image

Steps to reproduce

What are the steps we can take to reproduce this and verify it's fixed?

  1. Open VS Code
  2. Run stripe listen in terminal

Environment

MacOS

@auchenberg-stripe auchenberg-stripe added the bug Something isn't working label Jun 3, 2020
@auchenberg-stripe
Copy link
Contributor Author

auchenberg-stripe commented Jun 3, 2020

Seems to be a general xterm.js issue, as Hyper terminal doesn't render either:

Screen Shot 2020-06-03 at 2 33 04 PM

This should be supported per xtermjs/xterm.js#1134, so maybe some tiny differences?

@tomer-stripe
Copy link
Collaborator

@auchenberg-stripe xtermjs/xterm.js#1134 is still open and it doesn't seem like it's completely supported yet so I think this might be upstream of us.

@auchenberg
Copy link
Contributor

You are right. Its still open, and upstream. @tomer-stripe

@richardm-stripe
Copy link
Contributor

Closing as it doesn't represent a bug in the stripe-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants