Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC]: The new quotas API does not allow to set check interval #10311

Closed
fvaleri opened this issue Jul 7, 2024 · 7 comments · Fixed by #10335
Closed

[DOC]: The new quotas API does not allow to set check interval #10311

fvaleri opened this issue Jul 7, 2024 · 7 comments · Fixed by #10335

Comments

@fvaleri
Copy link
Contributor

fvaleri commented Jul 7, 2024

Related problem

The default check interval is 60 seconds, which may be too much for some use cases.
The only way to configure this is to use .spec.kafka.config, which is undocumented.

Suggested solution

Add checkIntervalSec to the quotas API with related documentation.

Alternatives

No response

Additional context

No response

@scholzj
Copy link
Member

scholzj commented Jul 7, 2024

What does too much mean? Too small? Too big?

@fvaleri
Copy link
Contributor Author

fvaleri commented Jul 7, 2024

What does too much mean? Too small? Too big?

Too big.

@scholzj
Copy link
Member

scholzj commented Jul 7, 2024

I guess if you make it smaller you just overload the Admin API without gaining too much.

BTW: The proposal specifically expects that Other options might be configured directly by the user in .spec.kafka.config section of the Kafka CR.

@fvaleri
Copy link
Contributor Author

fvaleri commented Jul 7, 2024

I guess if you make it smaller you just overload the Admin API without gaining too much.

I think it is useful to set a lower value, because a sudden and unexpected increase in the incoming bytes rate can fill up the disc in less than a minute, especially if you didn't leave room for this.

The plugin project itself sets the check interval to 5 seconds as an example in the main readme. In general, I feel this is an important configuration to expose through the API.

BTW: The proposal specifically expects that Other options might be configured directly by the user in .spec.kafka.config section of the Kafka CR.

Ok, I didn't remember that, but I don't think users read the proposal. Additionally, we have the following phrase in the changelog: the configuration of the plugin inside .spec.kafka.config is ignored and should be removed.

@scholzj
Copy link
Member

scholzj commented Jul 7, 2024

I think it is useful to set a lower value, because a sudden and unexpected increase in the incoming bytes rate can fill up the disc in less than a minute, especially if you didn't leave room for this.

I think you should plan with a sufficient buffer for this rather than play with the frequency of the check.

@fvaleri
Copy link
Contributor Author

fvaleri commented Jul 7, 2024

I think you should plan with a sufficient buffer for this rather than play with the frequency of the check.

I agree, but we have things like test clusters, perf and load tests, so there could be valid use cases for this.

@scholzj
Copy link
Member

scholzj commented Jul 11, 2024

Discussed on the community call on 10.7.2024: We should update the documentation to suggest that additional options can be configured in .spec.kafka.config.

@scholzj scholzj changed the title [Enhancement]: The new quotas API does not allow to set check interval [DOC]: The new quotas API does not allow to set check interval Jul 11, 2024
@PaulRMellor PaulRMellor self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants