Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An quest to add local phone number #6124

Closed
4 of 5 tasks
HafizBeyy opened this issue Feb 6, 2025 · 14 comments
Closed
4 of 5 tasks

An quest to add local phone number #6124

HafizBeyy opened this issue Feb 6, 2025 · 14 comments
Labels
feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@HafizBeyy
Copy link

HafizBeyy commented Feb 6, 2025

General

Purpose of this quest addition: Having phone numbers of places is generally very useful thing. For example, when you want eat some desired place, you can call them to ask for menu or prices. And this important data is very missin in OpenStreetMap. I think StreetComplete should lead contributors to add this data by adding this quest into the app.
Affected tag(s) to be modified/added: phone
Question asked: What is the local phone number of this place?

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by any pedestrian from the outside but a survey is necessary (pedestrian might need to look for a phone number or ask employees for that information)
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • 🕓 Applies to a reasonable number of map data (Worth the effort)

Ideas for implementation

Element selection:
No elements. An input should make it.

Metadata needed:
Country metadata. This way pedestrian doesnt need to enter country code.

Proposed UI:
A big popup with wide input space at the middle, country flag and code at the start. As user types, app automatically put spaces as the regular number typing in that country (for Türkiye we eventually type our phone numbers like this: +90 555 000 55 00 )

@HafizBeyy HafizBeyy changed the title An quest to add local phone number or email of a place An quest to add local phone number Feb 6, 2025
@matkoniecz
Copy link
Member

Has anything changed since #2043 ?

@matkoniecz matkoniecz added the feedback required more info is needed, issue will be likely closed if it is not provided label Feb 6, 2025
@matkoniecz
Copy link
Member

matkoniecz commented Feb 6, 2025

🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)

what would be tagged if there is no phone number to the POI?

@matkoniecz
Copy link
Member

matkoniecz commented Feb 6, 2025

Wait, it looks like it was discussed also in #2839

This one is more specific so I am fine with it existing as a separate issue (but if someone would close it as a duplicate I would not be opposed)

@riQQ
Copy link
Collaborator

riQQ commented Feb 6, 2025

Element selection:
No elements. An input should make it.

This is about the entities for which the quest should be asked? Which (main) tags? Restaurants? Shops? Hotels? Street cabinets?

@HafizBeyy
Copy link
Author

Element selection:
No elements. An input should make it.

This is about the entities for which the quest should be asked? Which (main) tags? Restaurants? Shops? Hotels? Street cabinets?

I think every kind of commercial place should have asked about this. If there is not, user just tag it as no phone number.

@mcliquid
Copy link
Contributor

mcliquid commented Feb 7, 2025

If there is not, user just tag it as no phone number.

What is the established tag for “no phone number”?

EDIT: To add a little bit context: If there is no established tag that can be saved to the object, then it cannot be filtered by it. StreetComplete needs some kind of tag on the object that says “There is no phone number here”, otherwise the quest will be displayed an infinite number of times in succession because the quest always wants to know “What is the phone number here?”.

Let me invent something stupid like “no:phone=yes”. That's really bad syntax but let me illustrate it.
If we filter for all commercial places in the quest, we have to filter them firstly by the fact that they have no phone number and secondly by the fact that someone has already said before that there is no phone number (no:phone=yes or whatever).
StreetComplete does not see it as a task to introduce new tags, so we have to rely on existing tagging here.
Do you think this already exists?

@matkoniecz
Copy link
Member

What is the established tag for “no phone number”?

#2839 (comment) ?

@mnalis
Copy link
Member

mnalis commented Feb 7, 2025

I think every kind of commercial place should have asked about this.

Have you looked at Quest guidelines, especially "💤 No spam" and "🤔 No unanswerable quests"?

I've been using such quest in SCEE (StreetComplete "Expert edition" fork) as noted in #2839 (comment), and while I like the quest, it has problems with especially those two issues. I'd say that here (Croatia) maybe 10-20% of the shops/amenities have phone number signed, and rest do not.

So, in majority of the cases here one has to hide the quest locally, but that is:

  • rather tiresome (unless one is really into mapping that specific data)
  • does not help with quest popping up for everyone else who will be asked the same quest over and over again

So even I only enable that quest in few profiles, and have it disabled in all the others...

If there is not, user just tag it as no phone number.

But what would StreetComplete write in OpenStreetMap database in that case, to avoid question popping up again for another user (i.e. which OSM key=value tag should be uploaded to OSM database)?

@mcliquid
Copy link
Contributor

mcliquid commented Feb 7, 2025

#2839 (comment) ?

I see that “established” can be interpreted in different ways :)

@HafizBeyy
Copy link
Author

If there is not, user just tag it as no phone number.

What is the established tag for “no phone number”?

yeah you're right. There is no tag to prevent asking phone numbers infinitily if there is not. so this is not a good idea for a quest until OSM devs add an option to specify no phone number. So think it as a line to edit POI when in "places" overlay.

@mnalis
Copy link
Member

mnalis commented Feb 8, 2025

so this is not a good idea for a quest until OSM devs add an option to specify no phone number

Yes, it is unfortunate, but I concur with your conclusion.

So think it as a line to edit POI when in "places" overlay.

That is however outside of the scope of Overlays. See Overlay guidelines, especially "🔎 One aspect".

While I understand (and as a power user, even agree) that it would be nice to be able to add multiple attributes about a shop (like phone number, website, facebook page, wikimedia_commons picture etc.), it is not what Overlays were intended for. Requests for modifying overlays in that way that have so far been rejected AFAICT.

If you prefer that style of editing (multiple attributes to manually set on each POI if existing, or ignoring them if not existing), I can recommend trying out Every Door, or MapComplete / Vespucci / OsmAnd on mobile (or JOSM and iD and again MapComplete on desktop).

You can even use them in conjuction with StreetComplete -- in StreetComplete, just long-press on the location on the map and choose "Open location in another app", and all compatible installed apps will be offered. So you can do most editing in StreetComplete, and jump to one of the other apps to update that specific POI which lacks information not supported by StreetComplete.

@matkoniecz
Copy link
Member

until OSM devs add an option to specify no phone number

note that it is rather done by OSM community - if you think that this kind of tagging makes sense then anyone can start using it also without editor support, tagging tags directly

I closed #2839 for now as website:signed=no and email:signed=no have literally zero usage across entire planet, contact:website:signed=no - has a single use, contact:email:signed has also zero. And tagging them is quite dubious.

I am considering closing also this one as phone:signed=no seems barely used, though it seems to make more sense.

until OSM devs add an option to specify no phone number

admittedly there were cases of editor developers pushing some tags unwanted by community or establishing them by force - in some cases it even succeeded

but doing this really should be avoided and I have no good explanation why tagging millions of phone:signed=no would be worth it

@matkoniecz matkoniecz closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2025
@westnordost
Copy link
Member

By the way, I find it to be a more useful data point to record the website of a shop than the phone number because a lot of other information can be sourced and/or crosschecked from the website, i.e. opening hours, operator, address, email, if it still exists, phone number, fax, etc.., including of course to be displayed directly in an end-user app like OrganicMaps.

But of course, it is more likely that a shop has a phone number signed than a website signed. Also, whether they have a website or not will be very dependent on the region.

So, to implement these in the app, the following things would need to be overcome first, in my opinion:

For both website and phone

  • ask in the community forums if it would be fine if <...>:signed=no would appear en-masse on shops, as even in developed cities, many shops will have neither of these

  • determine in which regions it would be okay to ask for this information at all because there is a reasonable chance that they have this info signed and enable the quest(s) only there OR disable by default with no by-country-limitation

For Phone

  • phone numbers must be specified with the international calling code of that region plus area code. Most shops will not include the international calling code, and some will not include the area code in the signed information. The former could be added automatically, the latter may be a problem.

@HolgerJeromin
Copy link
Contributor

Most shops will not include the international calling code,

Vespucci reformat a phone number to cover this.
The berlin number 0301234567 is reformated as +49 30 1234567

and some will not include the area code in the signed information.
The former could be added automatically, the latter may be a problem.

You are right.
Perhaps this can be detected. (missing start with +49, 0 or 00 in germany)
With all the mobile phones a number without area code is much less useful even for the shops sign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

7 participants