-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An quest to add local phone number #6124
Comments
Has anything changed since #2043 ? |
what would be tagged if there is no phone number to the POI? |
Wait, it looks like it was discussed also in #2839 This one is more specific so I am fine with it existing as a separate issue (but if someone would close it as a duplicate I would not be opposed) |
This is about the entities for which the quest should be asked? Which (main) tags? Restaurants? Shops? Hotels? Street cabinets? |
I think every kind of commercial place should have asked about this. If there is not, user just tag it as no phone number. |
What is the established tag for “no phone number”? EDIT: To add a little bit context: If there is no established tag that can be saved to the object, then it cannot be filtered by it. StreetComplete needs some kind of tag on the object that says “There is no phone number here”, otherwise the quest will be displayed an infinite number of times in succession because the quest always wants to know “What is the phone number here?”. Let me invent something stupid like “no:phone=yes”. That's really bad syntax but let me illustrate it. |
|
Have you looked at Quest guidelines, especially "💤 No spam" and "🤔 No unanswerable quests"? I've been using such quest in SCEE (StreetComplete "Expert edition" fork) as noted in #2839 (comment), and while I like the quest, it has problems with especially those two issues. I'd say that here (Croatia) maybe 10-20% of the shops/amenities have phone number signed, and rest do not. So, in majority of the cases here one has to hide the quest locally, but that is:
So even I only enable that quest in few profiles, and have it disabled in all the others...
But what would StreetComplete write in OpenStreetMap database in that case, to avoid question popping up again for another user (i.e. which OSM |
I see that “established” can be interpreted in different ways :) |
yeah you're right. There is no tag to prevent asking phone numbers infinitily if there is not. so this is not a good idea for a quest until OSM devs add an option to specify no phone number. So think it as a line to edit POI when in "places" overlay. |
Yes, it is unfortunate, but I concur with your conclusion.
That is however outside of the scope of Overlays. See Overlay guidelines, especially "🔎 One aspect". While I understand (and as a power user, even agree) that it would be nice to be able to add multiple attributes about a shop (like phone number, website, facebook page, wikimedia_commons picture etc.), it is not what Overlays were intended for. Requests for modifying overlays in that way that have so far been rejected AFAICT. If you prefer that style of editing (multiple attributes to manually set on each POI if existing, or ignoring them if not existing), I can recommend trying out Every Door, or MapComplete / Vespucci / OsmAnd on mobile (or JOSM and iD and again MapComplete on desktop). You can even use them in conjuction with StreetComplete -- in StreetComplete, just long-press on the location on the map and choose "Open location in another app", and all compatible installed apps will be offered. So you can do most editing in StreetComplete, and jump to one of the other apps to update that specific POI which lacks information not supported by StreetComplete. |
note that it is rather done by OSM community - if you think that this kind of tagging makes sense then anyone can start using it also without editor support, tagging tags directly I closed #2839 for now as I am considering closing also this one as
admittedly there were cases of editor developers pushing some tags unwanted by community or establishing them by force - in some cases it even succeeded but doing this really should be avoided and I have no good explanation why tagging millions of |
By the way, I find it to be a more useful data point to record the website of a shop than the phone number because a lot of other information can be sourced and/or crosschecked from the website, i.e. opening hours, operator, address, email, if it still exists, phone number, fax, etc.., including of course to be displayed directly in an end-user app like OrganicMaps. But of course, it is more likely that a shop has a phone number signed than a website signed. Also, whether they have a website or not will be very dependent on the region. So, to implement these in the app, the following things would need to be overcome first, in my opinion: For both
|
Vespucci reformat a phone number to cover this.
You are right. |
General
Purpose of this quest addition: Having phone numbers of places is generally very useful thing. For example, when you want eat some desired place, you can call them to ask for menu or prices. And this important data is very missin in OpenStreetMap. I think StreetComplete should lead contributors to add this data by adding this quest into the app.
Affected tag(s) to be modified/added: phone
Question asked: What is the local phone number of this place?
Checklist
Checklist for quest suggestions (see guidelines):
Ideas for implementation
Element selection:
No elements. An input should make it.
Metadata needed:
Country metadata. This way pedestrian doesnt need to enter country code.
Proposed UI:
A big popup with wide input space at the middle, country flag and code at the start. As user types, app automatically put spaces as the regular number typing in that country (for Türkiye we eventually type our phone numbers like this: +90 555 000 55 00 )
The text was updated successfully, but these errors were encountered: