-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in-app log viewer #3597
Comments
I guess this is forthcoming of you, but I don't need a public issue in this tracker for everything I plan to do for this app. |
This comment has been minimized.
This comment has been minimized.
Is this something I can assign to you, @matkoniecz ? I think I rememeber you mentioning you wanted to work on this? |
Here is a rough outline how it should look. Interface-wiseI think easiest would be to let our interface Logger {
fun i(tag: String, message: String)
// ... etc
}
object Log {
var instance: Logger? = null
override fun i(tag: String, message: String) = instance?.i(tag, message)
// ...etc
}
class AndroidLogger : Logger {
// implement...
} And on application start, Implementation-wiseThe AndroidLogger should append the logs into a database table. Logs that exceed a certain size (or age) must be deleted. Maybe using the same mechanism as old quest data is deleted. UIIn the about screen next to the links to reporting a bug etc, there should be a link to a list-view of the log. For the best utility, it should have the following features:
* since the app should not require file storage permission, exporting to a file in e.g. Downloads directory is out of question. Maybe "copy to clipboard" would work. Or "attach to mail (to [email protected])" would work. Maybe there is a better idea. Furthermore, whenever a crash report is sent, the part of the log directly preceding the crash should also be attached to the error-report mail. So, the log messages from the database are 1. displayed in a RecyclerView list and 2. can be converted into a newline-concatenated string |
@matkoniecz did not start working on it yet, so for the time being, this is free for the taking / can be done by other people interested in this. If you do, I can assign you to "reserve" this. |
Use case
To help debug issues, in-app log viewer would be useful.
Proposed Solution
It has been mentioned several times by @westnordost, and that @matkoniecz might want to do it and that the ticket for it would be created, but is seems to have slipped, so I'm opening this one.
See for example #3290 (comment), #1892 (comment), #3406 (comment)
The text was updated successfully, but these errors were encountered: