-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic reconciler metrics #689
Conversation
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
@freeznet:Thanks for providing doc info! |
@freeznet:Thanks for providing doc info! |
the metrics port(8080) is not exposed in the chart, shall we expose it? |
@jiangpengcheng I have exposed the port by service, PTAL when you have time, thanks. |
Fixes #655
Motivation
provide health and performance metrics
Modifications
monitoring
packageFunctionMeshControllerReconcileCount
metricsFunctionMeshControllerReconcileLatency
metricsVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)