Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(useWait): remove useWait hook #711

Merged
merged 1 commit into from
Nov 1, 2019
Merged

feat(useWait): remove useWait hook #711

merged 1 commit into from
Nov 1, 2019
+0 −99

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Oct 27, 2019

As an implementation of #708

@xobotyi xobotyi requested review from wardoost and streamich October 27, 2019 19:30
@xobotyi xobotyi added the enhancement New feature or request label Oct 27, 2019
streamich
streamich reviewed Oct 27, 2019
View reviewed changes
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we make it a breaking change? I.e. delay merging until we release next major.

@xobotyi
Copy link
Contributor Author

xobotyi commented Oct 27, 2019 •
edited
Loading

@streamich i'm pretty sure that all react-wait users are using directly react-wait's hook.
I think we can make a patch version with a deprecation message and minor version with deleted hook, IMO no sense to wait untill the major (actually i want to do some library sources sanitization before v13 release).
If you agree i'll make a second PR with deprecation mesages

@xobotyi
Copy link
Contributor Author

xobotyi commented Oct 27, 2019

Also react-wait is abandoned already for a year and it's types defenition beaks most of current react version upgrades. #622 #577 #686 and soo on strictly related to react and typescript

This was referenced Oct 30, 2019
Merged
Closed
@xobotyi xobotyi requested a review from streamich October 31, 2019 21:22
@xobotyi xobotyi self-assigned this Oct 31, 2019
@streamich streamich changed the base branch from master to v13 November 1, 2019 21:29
streamich
streamich approved these changes Nov 1, 2019
View reviewed changes
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streamich streamich merged commit 8d40f18 into v13 Nov 1, 2019
@streamich streamich deleted the remove-react-wait branch November 1, 2019 21:30
streamich pushed a commit that referenced this pull request Nov 1, 2019
@semantic-release-bot
chore(release): 13.0.0 [skip ci]
d08490d 
# [13.0.0](v12.13.0...v13.0.0) (2019-11-01)

* Merge pull request #711 from streamich/remove-react-wait ([8d40f18](8d40f18)), closes [#711](#711)

### Features

* remove useRefMounted hook ([ad74d3d](ad74d3d))
* **useRefMounted:** remove obsolete hook; ([dc364c8](dc364c8))
* **useWait:** removed from package due to it is simple reexport of other package; ([d7c38bd](d7c38bd))

### BREAKING CHANGES

* useWait hook has been removed from react-use
* deprecated useRefMounted hook is now removed, use useMountedState hook instead
@streamich
Copy link
Owner

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich streamich approved these changes

@wardoost wardoost Awaiting requested review from wardoost

Assignees

@xobotyi xobotyi

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @streamich