Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async test warnings #543

Merged
merged 2 commits into from
Aug 20, 2019
Merged

fix: async test warnings #543

merged 2 commits into from
Aug 20, 2019

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Aug 20, 2019

useAsync tests been missing render await in onBefore stage;
useAsyncFn tests been missing act calls;

@xobotyi xobotyi requested a review from streamich August 20, 2019 10:36
Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@streamich streamich merged commit 7af237e into master Aug 20, 2019
@streamich streamich deleted the fixAsyncTests branch August 20, 2019 20:34
streamich pushed a commit that referenced this pull request Aug 20, 2019
## [10.7.1](v10.7.0...v10.7.1) (2019-08-20)

### Bug Fixes

* async test warnings ([#543](#543)) ([7af237e](7af237e))
@streamich
Copy link
Owner

🎉 This PR is included in version 10.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants