Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor highlight disappears off-screen when using down cursor through expanded list of albums that does not fit one on-screen #1489

Open
3 tasks done
DavidPesticcio opened this issue Jul 15, 2024 · 1 comment

Comments

@DavidPesticcio
Copy link

  • I have checked the FAQ for answers.
  • I have checked the Changelog that the issue is not already fixed.
  • I believe this issue is a bug, and not a general technical issue, question or feature requests that can be discussed on the forum.

Describe the bug
While navigating with down cursor keys through an artist with enough albums that continue off-screen e.g. "Various Artists", the cursor does not remain visible on-screen at the lowest visible album position while the list scrolls upwards.

Instead, after continuing to move the cursor highlight down with the down cursor key it will move off-screen. Then after pressing the down cursor key some number time off-screen, the visible list then jumps up a page or so until you can see the cursor highlight at the bottom of the screen.

If you continue pressing the down cursor key, this behaviour repeats until the end of the list is reached - if the end of the list is a multiple of when the scrolling jumps, you may not reach the last item as it is likely off-screen, although sometimes this is not the case and you can reach the last item as expected.

It seems like an incorrect calculation of the number of items in an expanded album entry is not being calculated according to the available visible space and it causing an incorrect offset for the cursor highlight position.

To Reproduce

The spanner options of the "Search terms" box are set as follows:

  1. Show: Entire collection
  2. Group by: Group by Album-artist / Year - Album - Disc
  3. Show all songs

To replicate behaviour, use the following steps;

  1. Select an artist with enough albums that they do not all fit on-screen and expand the list
  2. Use the up cursor key to move the cursor highlight up to the top of the screen until the list moves down - this works as expected
  3. Use the down cursor key to move the cursor highlight down to the bottom of the screen until it disappears past the last visible entry - this is not what is expected
  4. The cursor highlight will continue further off-screen until a point when the page will jump to show the cursor highlight at the bottom of the screen (which appears to be in the correct position)
  5. The jump appears to happen after the cursor has moved down by a screen-full count of items, minus three
  6. If you continue to use the down cursor key to move the cursor highlight down the process repeats as from step 3 above.
  7. When you reach the bottom of the list of artist albums, the problem persists if you continue moving the cursor highlight or the remaining artists - that may or may not be expanded

Expected behaviour
The cursor highlight should remain visible and the list items should scroll accordingly with when using cursor keys to move the cursor highlight down.

Screenshots:
N/A

System Information:

  • Operating system: Linux
  • Strawberry Version: Version 1.1.0-rc4

Additional context
None

@jonaski
Copy link
Member

jonaski commented Jul 16, 2024

Looks like a Qt bug to me, but I have to test more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants