Skip to content

Commit

Permalink
comment with issue
Browse files Browse the repository at this point in the history
  • Loading branch information
thejaminator committed Dec 3, 2023
1 parent 11d5e4f commit b4f838e
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@ def create_user(self, input: CreateUserInput) -> Union[UserType, UserError]:
try:
data = input
except pydantic.ValidationError as e:

Check warning on line 176 in tests/experimental/pydantic_first_class/schema/test_mutation.py

View check run for this annotation

Codecov / codecov/patch

tests/experimental/pydantic_first_class/schema/test_mutation.py#L174-L176

Added lines #L174 - L176 were not covered by tests
# issue: the error will never be thrown here because the validation
# happens in convert_argument
args: Dict[str, List[str]] = {}

Check warning on line 179 in tests/experimental/pydantic_first_class/schema/test_mutation.py

View check run for this annotation

Codecov / codecov/patch

tests/experimental/pydantic_first_class/schema/test_mutation.py#L179

Added line #L179 was not covered by tests
for error in e.errors():
field = error["loc"][0] # currently doesn't support nested errors
Expand Down

0 comments on commit b4f838e

Please sign in to comment.