diff --git a/.verify-floor.json b/.verify-floor.json index 3b93b3a..d13073d 100644 --- a/.verify-floor.json +++ b/.verify-floor.json @@ -4,6 +4,6 @@ "skipped_max": 26, "selftest_skipped_max": 7, "gate_skipped_max": 2, - "note": "Recorded by verify.py --update-floor, except the *_max ceilings, which are edited BY HAND and never re-measured. `collected` catches tests that stopped being collected; `passed` is compared against passed+skipped, so a check may move between passing and consciously-skipped but the two together may never shrink. The *_max ceilings bound the skipped side: 24/7/2 is exactly what a machine with none of this instance's local prerequisites skips (a GitHub runner: no agent CLIs, no ~/.codex/skills, no /Applications/ChatGPT.app, no populated capability ledger), measured 2026-08-21. On the owner's machine all prerequisites exist and nothing skips at all. Raising a ceiling is a deliberate act: it means agreeing that one more thing is allowed to go unchecked, so say which and why in the commit. LOWERED 26 -> 24 on 2026-08-22, reverting the raise made earlier the same day. The two kill-switch exemption tests no longer need to skip on a bare runner: their declarations moved out of the running instance's ledger and into capabilities.KNOWN_DECLARATIONS, so they assert code-derived truth and run everywhere. Moving a test back below the ceiling is the preferred way to lower it -- fix what made it machine-dependent, rather than agreeing to check less. FLOOR 345 -> 353 on 2026-08-22: 345 was measured on a branch cut before #13 (research panels/rounds/domain studies) merged, so the recorded floor sat 8 tests BELOW what main actually collects. A floor below reality is the permissive direction -- those 8 could have silently stopped being collected and still cleared the check, which is exactly the hole this file exists to close. Measure the floor on the merge result, not on the branch. Raised again on 2026-08-22 by the producer-identity-scope branch, which adds tests on top of the 353 recorded by #15; re-measured after rebasing rather than assumed. NOTE: `verify.py --update-floor` REPLACES this note with a generic one, so it must be restored by hand after every use \u2014 the ceiling rationale is the only record of which prerequisite justifies each skip. FLOOR 365 -> 366 on 2026-08-22 (heartbeat-ordering work, PR #18): exactly one new test, test_capabilities.test_no_tick_producer_runs_above_the_heartbeat_export. No ceiling moved and nothing new is skipped -- it reads source files rather than a populated ledger, so it runs on any machine. The branch recorded 354 because it was cut before #16 merged; re-measured on the MERGE RESULT per the rule above, which is exactly the mistake that put the floor 8 below reality last time. FLOOR 366 -> 368 on 2026-08-23: main collected 368 while this file recorded 366, drift left by #34 (evidence-acquisition landed, +1) and #37 (tick capability evidence, +1) whose authors each measured against a branch cut before the other merged. A floor BELOW reality is the permissive direction this file exists to close -- those two could have silently stopped being collected and still cleared the check. Measured on the merge result per the rule above: 368 passed, 0 failed, 0 skipped, 83/83 selftests, 43/43 can-fire, 5/5 gates. CEILING 24 -> 26 and FLOOR 368 -> 387 on 2026-08-23 (profiles/provenance branch, PR #42). This file CONFLICTED with #50, which raised the floor 366 -> 368 on main while this branch raised it to 387; resolved as the UNION rather than by taking a side -- #50's rationale is retained above and the count was RE-MEASURED on the new merge result instead of keeping either number. 368 (main) + 19 (this branch's net new tests) = 387; #50 corrected recorded drift rather than adding coverage, which is why 387 is unchanged from the pre-conflict measurement. Measured in a runner sandbox reproducing CI exactly (361 passed, 26 skipped, 387 collected) AND on the owner's machine (387 passed, 0 skipped, 5/5 gates). The two new skips are drift detectors against a REAL installed agent runtime, so neither can be moved below the ceiling -- the preferred way to lower one: (1) agy advertised-models cache absent, since comparing declared model ids against the catalogue agy actually advertises needs that catalogue, and a fixture would exercise the comparison while detecting no real drift; (2) vibe config absent (~/.vibe/config.toml), since active_model cannot be read to check for drift when there is no config to read. Both name their missing prerequisite, so a green run still states what it did not check. A third candidate skip was REFUSED: dispatcher's per-run agy-log assertion failed on a bare runner because adapters.advertised_models shells out to `agy models` when its disk cache is cold, and that probe landed inside a monkeypatched subprocess.run and overwrote the captured command. That is a stub leak, so it was fixed by ISOLATING the double rather than by skipping -- which makes CI run MORE. FLOOR 387 -> 391 on 2026-08-23 (improvement-log accessor, PR #59): exactly four new tests, all in test_improvement_log.py -- three read tracked files in the tree (the pointer's size and content, and that CLAUDE.md 0 step 3 and 5 name the accessor rather than a bare path) and one runs the accessor as a subprocess against a path that cannot exist. None reads a populated ledger, an agent CLI or ~/.codex, so all four RUN on a bare runner and NO ceiling moved: nothing new is skipped. Measured on the MERGE RESULT after rebasing onto origin/main af6654d, which collected 387 -- not on the branch base, per the rule above. FLOOR 391 -> 402 on 2026-08-23 (Gate python-ci configuration, the PR that adds the missing .github/workflows/autofix-versions.env): exactly 11 new tests, all in test_ci_gate_config.py, which read committed files only -- the pin file, ruff.toml, mypy.ini, pr-00-gate.yml's toggle annotations and docs/CI_LINT_BASELINE.md. NO ceiling moved. On any CHECKOUT -- CI, the owner's tree, a second instance -- all 11 run: they need no installed linter and no populated ledger. In the EXEC-MIRROR layout all 11 skip with one named reason, because orch-sync-mirror.sh copies root-level *.py only, so .github/workflows, docs/ and scripts/ are genuinely absent there (env_prereq.repo_files_absent). That lands at 11/26 on a machine that otherwise skips nothing, and CI stays at 26/26, so no ceiling needed raising. The skip gate is the presence of those DIRECTORIES, never of the pin file itself -- gating on the file would have made the test that checks for it unable to fail. Measured on the merge result, twice: the branch was rebuilt on origin/main after #42 and #59 merged, and re-measured after #61 merged and was merged in -- 393 passed + 9 skipped = 402 collected both times, so #61 added no collected tests and this floor is not sitting below reality. #61 itself left main's floor at 391, which is exactly main-without-these-11, so there is no inherited drift to correct. RULE CHANGE 2026-08-23: `collected` is now an EQUALITY, not a minimum. Every floor entry above this one records the number being found BELOW reality and hand-raised after the fact -- 21 low at the worst, then 8, then 1, then 2 -- because nothing ever required a test-adding PR to touch this file, so the permissive direction was silent by construction and the rule 'measure on the merge result' had to be restated three times with nothing enforcing it. verify.py now FAILS when collected exceeds the floor, printing the two integers to write. That also makes the concurrency case self-enforcing: once every test-adding branch must edit these same two lines, two concurrent branches CONFLICT IN GIT, so the second cannot merge without rebasing onto the first and re-measuring on the actual merge result. Demonstrated repeatedly on the change itself: six merges landed on main in the two hours it took to write, moving this file 368 -> 387 -> 391 -> 402, and every one would have left the floor below reality under the old one-directional rule. `passed` deliberately stays a MINIMUM on passed+skipped: only collection is machine-invariant (a skipped test is still collected), measured across machines at 391 collected on both, with pass/skip splits of 365/26 on CI against 391/0 locally. The *_max ceilings are untouched by this change and nothing new is skipped. `--update-floor` also stops REPLACING this note -- it appends -- so the warning above about restoring it by hand no longer applies; and drift does NOT block --update-floor, since a gate that forbade its own only remedy would be a deadlock (the first draft was exactly that). FLOOR 402 -> 407 on 2026-08-23 (findability admission requirement). (findability admission requirement). (findability admission requirement). (findability admission requirement). Exactly five new pytest tests, all in test_capability_admission.py: test_findability_distinguishes_its_three_sub_causes, test_findability_blocks_new_capabilities_and_reports_older_ones_as_debt, test_unreadable_reach_is_not_evaluated_and_never_a_failure, test_findability_exemption_is_declared_in_code_not_in_a_live_ledger, test_consult_sites_are_falsifiable_claims_about_real_callers. NO CEILING MOVED and nothing new skips: all five build synthetic ledgers in a tempdir or read committed tables, so none needs a populated capability ledger, an agent CLI or ~/.claude/skills. The one machine-dependent thing they touch -- an external consult site declared in capability_advisor.CONSULT_SITES whose skill prompt is not on this machine -- is reported as UNVERIFIED rather than skipped, because absence of the caller is not refutation of the claim; the in-tree site (tick) is asserted verified on every machine so the check can never degrade into 'everything unverified, nothing tested'. Measured on the merge result per the rule above: this file CONFLICTED three times while the branch was open, as main went 387 -> 391 -> 402 (#61, #64, #65, #60). Each time it was resolved as the UNION rather than by taking a side, and the count was RE-MEASURED on the new merge result rather than either number being carried forward: 402 (main at bd6da2e) + 5 (this branch's new tests) = 407. That is the rule this file already states -- measure the floor on the merge result, not on the branch -- and it mattered here, because #60 both deleted test_ci_gate_config.py and added more than it removed, so guessing in either direction would have been wrong. -> re-measured on 2026-08-23 (PR #62, the four deferred #42 review findings): three new tests, all machine-independent (each builds its own tmp_path Brain and manifests), so NO CEILING MOVED and nothing new is skipped. Fourth conflict for this branch, and the first one under the EQUALITY -- which is the point: the equality's own rationale says git conflict detection is what enforces 'measure on the merge result', and that is exactly what happened here. Under the old minimum the three earlier conflicts could each have been resolved by keeping the larger number; under the equality the count MUST be measured, and it was. RESOLVED AGAINST #68 (findability admission requirement) on 2026-08-23: taken as the UNION per the rule this file states -- #68's five-test entry is retained above and this branch's three-test entry beside it -- and the count RE-MEASURED on the merge result rather than keeping either side's number. main fc1fd42 collects 407; this branch adds 3; 410 measured with `pytest --collect-only -q` on the merge result, not assumed. Ceilings untouched at 26/7/2 and nothing new is skipped. Also resolved in the same merge: langsmith-fleet-worker-attempt.json, a CI-emitted `langsmith-fleet/v1` worker-attempt record whose two sides differed only in `emitted_at` and `pr_number` (62 here, 68 on main). Main's NEWER record was kept rather than this branch's older one -- discarding a newer provenance observation to win a merge would corrupt exactly the causal-provenance evidence CLAUDE.md 2 protects, and this branch's own run re-emits its record anyway. FLOOR 410 -> 411 on 2026-08-23 (CodeRabbit follow-up on PR #42, thread 3837879039; re-measured again after #56 made `collected` an EQUALITY, which makes an assumed number a hard RED rather than a quiet pass -- main stayed at 402 across #56, and the merge result measures 403, so #56 added no collected tests and this is main's 402 plus this branch's one): exactly one new test, test_feedback_model_provenance.test_late_sweep_completes_terminal_attempts_never_one_in_flight, which pins that ledger_reconcile.resolve_unresolved_worker_attempts completes only TERMINAL unresolved worker attempts and never one still in flight. No ceiling moved and nothing new is skipped -- the test builds its own tmp ledger and codex rollout fixture and monkeypatches adapters.CODEX_SESSIONS, so it needs no agent CLI and no populated capability ledger and runs on a bare runner. RESOLVED AGAINST #59 (improvement-log accessor), which raised the floor 387 -> 391 on main while this branch raised it to 388: taken as the UNION -- #59's rationale is retained above and the count was RE-MEASURED on the new merge result rather than keeping either number, which is the rule this file states and the mistake that once put the floor 8 below reality. 391 (main, incl. #59's four tests) + 1 (this branch's one new test) = 392 measured, not assumed: 392 passed, 0 failed, 0 skipped, 83/83 selftests, 43/43 can-fire, 5/5 gates. Three sibling follow-up branches are in flight against this same main (CI/ruff config, arm-attribution + durability, adapters label->ID); if this file conflicts with one of them, resolve as the UNION and RE-MEASURE on the new merge result rather than taking either number -- that is what #42 and #50 did, and taking a side is what put the floor 8 below reality earlier. RESOLVED AGAINST #68 (findability admission requirement) on 2026-08-23: taken as the UNION per the rule this file states -- #68's five-test entry is retained above and this branch's one-test entry beside it -- and the count RE-MEASURED on the merge result. main fc1fd42 collects 407; this branch adds 1; 408 measured with `pytest --collect-only -q` on the merge result, not assumed. Ceilings untouched at 26/7/2 and nothing new is skipped -- the one new test builds its own tmp ledger and codex rollout fixture, so it runs on a bare runner. Also resolved in the same merge: langsmith-fleet-worker-attempt.json, a CI-emitted `langsmith-fleet/v1` worker-attempt record differing only in `emitted_at` and `pr_number`; main's NEWER record was kept, since discarding a newer provenance observation to win a merge would corrupt the causal-provenance evidence CLAUDE.md 2 protects. FLOOR 411 -> 415 on 2026-08-23 (PR #70 diagnostics salvage): four new collected tests in test_capability_set_coverage.py from the PR #43 salvage plus CodeRabbit follow-ups on PR #51/#70 \u2014 union/missing-candidate fetch command, truncation after six modules, AST-scoped gate-call audit, and entrypoint-diagnosis coverage. NO CEILING MOVED and nothing new is skipped; all inject synthetic ledgers or read committed source. Measured on the merge result at 91d37fa: 389 passed + 26 skipped = 415 collected on CI, not assumed. FLOOR 415 -> 416 on 2026-08-23 (the dangling-citation follow-up, PR #74): exactly ONE new test, test_ci_gate_config.test_every_cited_repo_path_resolves, which reads the two committed config files this repo OWNS (the pin file and ruff.toml) and asserts every repo-relative path they cite exists. It exists because the pin file shipped citing docs/ci/LINT_BASELINE.md when the real path was docs/CI_LINT_BASELINE.md: the sibling checks read that file's CONTENTS thoroughly and its PROSE not at all, and the prose is the only pointer telling a reader where to re-measure before bumping a pin. Scoped to the two owned files deliberately -- scanning pr-00-gate.yml yields six findings that are all correct as written (guarded by hashFiles or a .agents check, or upstream paths), and a test that cries wolf gets waived. NO ceiling moved. RE-MEASURED SIX TIMES as the base moved under this ONE-LINE change: bd6da2e 402 -> ddb0928 402 -> fc1fd42 407 -> 0d661e3 407 -> 0593eeb 411 -> 6fed4ad 415, each +1 with this test, and the branch was rebuilt on each rather than the number carried forward. THIS BRANCH IS THE WORKED EXAMPLE of the equality's concurrency cost, so record it rather than rediscover it: main moved EIGHT times in the ~2.5 hours a one-line comment fix was open (#56, #68, #73, #69, #62, #70 and two direct commits), the floor line conflicted THREE separate times, and two merges overlapped the change directly -- #73 landed a byte-identical copy of the backplane-conformance.yml guard this branch also carried (dropped as redundant), and #69 edited this very test file in a neighbouring region. The equality is still the right call and should stay: every entry above this one records the floor being found BELOW reality, which is the permissive direction. But no amount of author care wins this race, because the correct value is only knowable on the merge result. The durable fix is CI running `verify.py --update-floor` on the merge commit, which keeps the equality and removes the race; until then a test-adding PR must be merged promptly after going green, because it re-conflicts on roughly every subsequent merge. FLOOR 416 -> 427 on 2026-08-23 (PR #72 hygiene untrack, rebased after #71 merged): exactly 11 new tests from test_repo_artifact_hygiene.py with root-anchored gitignore patterns. NO ceiling moved. Measured on merge result after #71 landed on main: 416 (main) + 11 = 427 collected via pytest --collect-only -q, not assumed. #71's simpler untrack landed first; this branch carries the full hygiene test suite and corrected root-anchored patterns. FLOOR 427 -> 428 on 2026-08-23 (PR salvaging #34/#42 remnants): exactly one new test, test_feedback_model_provenance.test_gemini_provenance_reads_the_per_run_log_before_the_conversation_store, recovered from #42's post-merge commit 4e0d6ae along with the adapters catalog work it exercises. No ceiling moved and nothing new is skipped -- it seeds adapters._ADVERTISED_MEMO instead of letting the catalog probe shell out, so it runs on any machine and adds no prerequisite. `passed` is 428 rather than the 426 verify.py suggested on this machine: two test_capabilities liveness tests (test_gate_blocks_execution_is_opt_in_and_narrow, test_evidence_gate_kind_is_not_blanket_observer) currently fail HERE on pristine main as well, because the hourly fleet tick mutated the machine-local ledger and range-lane-rollout now classifies matched_not_invoked rather than deliberately_gated. That is ledger STATE, not this branch and not the code -- CI bootstraps an empty ledger and counts 428/428. Recording 426 would have baked a local environment failure into the floor as though it were the expected result. FLOOR 428 -> 441 on 2026-08-23 (coverage measures what actually runs): exactly 12 new tests, all in test_verify_coverage_mode.py. They read committed files and verify.py's own source, and monkeypatch verify.COVERAGE in-process -- no populated ledger, no agent CLI, no ~/.codex, and no coverage RUN -- so all 12 execute on any machine and NO ceiling moved. The change itself is a measurement fix, not a gate: `verify.py --coverage` wraps each child in `coverage run --parallel-mode` and combines, because the per-module --selftest is a SUBPROCESS and a pytest-only coverage run cannot see it. That blind spot was most of the codebase -- 78 modules have no test_*.py at all, ~85,500 lines, 79.6% of non-test root Python -- so the reported 48.45% was measuring the gap in the instrument, not a gap in the tests. Combined: 76.1% (45,049 statements, 10,774 missed). Twelve of the twelve modules the old report named as worst were selftest-only; outcomes.py reported 9.0% and measures 61.9%, watch.py 9.6% -> 86.9%. Coverage is OFF by default and deliberately never touches the exit code -- one of the 12 tests pins that, because enforcing a threshold here would reward pytest wrappers around already-tested modules: metric up, assurance flat. Measured on the MERGE RESULT: branched from origin/main bcc68cd (floor 427), then REBASED onto f5f1c39 when it landed underneath and re-measured on the new merge result rather than carrying the old number: 428 + 13 = 441. +1 on 2026-08-23 (440 -> 441 after the rebase), same branch: test_the_cli_help_actually_renders. It exists because this branch BROKE `verify.py --help` and its own twelve tests did not notice. argparse interpolates help strings with `% params`, so the literal `~80%` in the --coverage help was read as an `%o` octal conversion and --help died with 'badly formed help string'. All twelve original tests passed: every one inspected source text or monkeypatched a flag, and not one RENDERED the help -- a construction-time test suite that never exercised the constructed thing, which is this repo's founding defect one layer up. CI's verify.py gate caught it, which is the check of last resort working as intended. The new test runs `verify.py --help` as a subprocess and asserts it exits 0, so it runs anywhere and NO ceiling moved. Rendering rather than grepping for `%` is deliberate: a grep would flag the legitimate `%(default)s`. FLOOR 441 -> 442 on 2026-08-23 (matched_not_invoked yields to observers and declared gates): exactly one new test, test_capabilities.test_matched_not_invoked_yields_to_observers_and_declared_gates. It is SYNTHETIC on purpose and that is the point of it: the two tests that caught this bug in the wild read the LIVE ledger, so they skipped with a named reason on the empty ledger ci.yml bootstraps -- the defect was red on every populated machine and green on CI for as long as it existed. A synthetic row asks the same question everywhere, so this one RUNS on a bare runner and NO ceiling moved. The fix itself moves matched_not_invoked below `observing` and below the DECLARED deliberately_gated check in classify_liveness: it was the first check, which made it the fourth instance of the unescapable label the comments in that function exist to fix. Audited before committing -- 12 of 43 live rows reclassify (ten observers to observing, two declared gates to deliberately_gated) and ZERO move for any other reason, so nothing is reclassified by inference and the weaker gate_reason-only branch is untouched. Measured on origin/main 0d9c3a7, whose recorded floor is 441, so 441 + 1 = 442. FLOOR RECORDED by verify.py --update-floor on 2026-08-23: collected=442, passed=442. Ceilings preserved, never re-measured \u2014 they are edited by hand. FLOOR RECORDED by verify.py --update-floor on 2026-08-24: collected=442, passed=442. Ceilings preserved, never re-measured \u2014 they are edited by hand. FLOOR RECORDED by verify.py --update-floor on 2026-08-24: collected=442, passed=442. Ceilings preserved, never re-measured \u2014 they are edited by hand. MYPY_EXEMPT_MAX introduced at 64 on 2026-08-23, the same change that flipped `typecheck` ON in pr-00-gate.yml. It was OFF because 608 whole-tree errors were drainable 0 per PR -- a gate whose clear path is blocked by the thing it measures. Two real changes opened it: the src/ move scoped the Gate's `target=src` to the 99 modules (608 -> 467), and pyproject.toml's [[tool.mypy.overrides]] exempts the modules that still have findings BY NAME so the 35 already-clean ones are checked today. 12 var-annotated findings were then drained (467 -> 455, 66 -> 64 modules) to prove the drain works rather than promise it. This ceiling may only ever be LOWERED, by typing a module and deleting its line -- raising it means agreeing one more module goes unchecked, so say which and why. NOT a suppression: no error code is disabled anywhere and the 455 stay visible via `python3 scripts/ci_lint_baseline.py`. Edited BY HAND like the other *_max values; --update-floor never re-measures it. MYPY_EXEMPT_MAX LOWERED 64 -> 43 on 2026-08-24, the ratchet's first real drain: 21 modules typed clean and removed from the exempt list, 455 -> 430 findings. Targeted the modules with 1-3 errors on purpose -- fixing 50 errors spread across the big modules would move this number by ZERO, and this number is what the gate reads. Lowering it is the drain; it may never be raised without naming the module and why. MYPY_EXEMPT_MAX LOWERED 43 -> 33 on 2026-08-24 (batch 2 of the drain): the whole <=5-finding tail typed clean. 66 of 99 modules now checked. What remains is five per-module campaigns (capability_advisor, dispatcher, capability_propensity, runtime_ac_gate, capabilities hold most of it), so future batches take ONE big module at a time rather than skimming. (batch 2 detail: 43 -> 26, 430 -> 374 findings, 73 of 99 modules checked. `mypy_path` gained `tests` so mypy can RESOLVE the recurrence-fixture roster capability_admission legitimately imports; the target stays `src`, but mypy then follows into that one test file, whose two findings were fixed rather than configured around.) MYPY_EXEMPT_MAX LOWERED 26 -> 20 on 2026-08-24 (batch 3): 79 of 99 modules checked. FLOOR 442 -> 448 on 2026-08-24 (absent-check detector + its ratchet): SIX new tests in tests/test_checks_reported.py holding the frequency rule and the expected-check ratchet. NO ceiling moved -- they call pure functions and read one committed JSON file, so they run on any machine. The ratchet exists because dogfooding the detector caught it DISARMING ITSELF: while pr-00-gate.yml sat held, every merged PR merged without the Gate, so after twelve such merges the Gate's checks fell below the 75% frequency threshold, the expected set eroded 23 -> 14, and PR #91 was pronounced clean by the tool written to catch exactly that. config/expected-checks.json is the high-water mark, seeded from PRs #87/#89 whose Gate demonstrably ran, and it only comes down when somebody deletes a line. LOWERED to 16 on 2026-08-24 (batch 4, re-applied after merging main, which carried #94/#100's own floor work \u2014 main's note kept, only the bound re-set). LOWERED 16 -> 16 on 2026-08-24 (batch 5): 83 of 99 checked. LOWERED 16 -> 12 on 2026-08-24 (batch 5): 87 of 99 checked. Lesson recorded three times now: measure with the PROJECT run, never per-file \u2014 `mypy src/X.py` reports clean for modules the project run still flags. FLOOR 448 -> 450 on 2026-08-24 (giving the per-node deliberate-break finding its consumers): exactly two new pytest tests, both in test_synthesis_promotion.py -- test_a_passing_break_names_the_tautologies_it_carried and test_the_break_caveat_is_silent_on_clean_and_on_pre_per_node_evidence. NO CEILING MOVED and nothing new is skipped: the first builds its own git repo in tmp_path and runs the real verification path (git + pytest only, no populated ledger, no agent CLI, no ~/.codex), and the second is a pure unit on _break_caveat. The third piece of this change is a runtime_ac selftest case, which adds NO collected test -- runtime_ac has a --selftest and synthesis_promotion does not, which is the whole reason only one of the two needed pytest tests. Measured on the merge result: branched from origin/main 8549f84, whose recorded floor is 448, and re-checked that main had not moved before writing this. 448 + 2 = 450, from verify.py's own count (450 passed, 0 failed, 0 skipped, 85/85 selftests, 5/5 gates), not assumed. FLOOR 448 -> 451 on 2026-08-24 (offload guidance correction, PR #113): THREE new tests in test_repo_artifact_hygiene.py -- two parametrized entries adding src/UNKNOWN.egg-info/PKG-INFO and UNKNOWN.egg-info/PKG-INFO to EMITTED_ARTIFACTS, and test_no_build_metadata_is_tracked. NO ceiling moved and nothing new skips: all three shell out to git against this checkout, so they run anywhere git does. They exist because THIS PR carried four committed build artifacts and no check objected. A CI step runs `pip install -e .`, setuptools writes src/UNKNOWN.egg-info/ (named UNKNOWN because pyproject.toml declares no [project] on purpose), and the repo's own autofix bot committed all four -- .gitignore had no *.egg-info/ entry and this suite only knew the langsmith-fleet family. CodeRabbit caught it; nothing local did. Both locations are listed because a checkout builds into src/ while the EXEC MIRROR IS FLAT. The tracked test is separate from the ignored test on purpose: the four files were committed BEFORE the pattern existed, and adding a pattern does nothing to a path git already tracks -- so an ignore-only check passes on a repo still carrying the debris. RESOLVED AGAINST #110 and #114 on 2026-08-24, which moved main 448 -> 450 while this branch raised it to 451: taken as the UNION per the rule this file states -- main's entries are retained above and this branch's three-test entry beside them -- and the count RE-MEASURED on the merge result rather than either number being carried forward. 450 (main) + 3 (this branch) = 453, measured with `pytest --collect-only -q`, not assumed. Ceilings untouched and nothing new is skipped. FLOOR 453 -> 458 on 2026-08-24 (untracking .coverage, the coverage database this repo's own verify.py writes): exactly FIVE new tests, all in test_repo_artifact_hygiene.py -- two parametrized ignore cases over COVERAGE_DATA_FILES (.coverage and a parallel-mode .coverage...), one untracked case, and two parametrized must-stay-committable cases (.coveragerc, tools/coverage_guard.py). NO CEILING MOVED and nothing new is skipped: all five ask GIT about a path in this checkout (check-ignore / ls-files) and need no populated ledger, no agent CLI and no ~/.codex, so all five RUN on a bare runner. The change is `git rm --cached .coverage` plus root-anchored `/.coverage` and `/.coverage.*`; the 90 KB SQLite database arrived on main in #109, a typing PR whose every other file is about mypy, and verify.py's coverage_reset() unlinks it and coverage_combine_and_report() rewrites it on every --coverage run -- so while tracked it was an opaque binary rewritten by the command that produces this repo's verdict. Both patterns because two different steps write them, and `/.coverage.*` rather than `/.coverage*` because the second swallows .coveragerc. Break -> revert performed in all three directions and recorded in the test file. Measured on the MERGE RESULT: fast-forwarded onto origin/main 5c769e0, whose recorded floor is 453, and re-fetched to confirm main had not moved again before measuring. 453 + 5 = 458 from verify.py's own count (458 passed, 0 failed, 0 skipped, 85/85 selftests, 5/5 gates), not assumed. LOWERED 12 -> 10 on 2026-08-24 (batch 6): keepalive_outcomes (17 findings) and redirect_sweep (18) typed clean, 89 of 99 modules checked, 240 -> 205 findings. Both modules were drained by WRITE-MODE isolated offloads (dispatcher.offload --isolate) rather than in-seat, and every diff was reviewed here before it was applied -- the two changes that could have altered behaviour were checked first-person and both are equivalent: redirect_sweep's marker-rc read keeps the same except clause wrapping it, so a non-numeric rc still raises inside the try and still lands at None; keepalive_outcomes' added `oc is not None` guard short-circuits ahead of _should_record_outcome, whose own first line already returns False on oc is None. LOWERED 10 -> 7 on 2026-08-24 (batch 6b): dispatcher (65 findings), capability_propensity (47) and runtime_ac_gate (34) typed clean, 92 of 99 modules checked, 205 -> 91 findings. All three drained by write-mode isolated offloads and then INTEGRATED BY HAND rather than applied as returned -- three of the agents' choices were replaced with smaller ones, and the reasons are the durable part. (1) capability_propensity came back with two `type: ignore`s at the correlated-arm lookup, justified as an ambiguous key type. The ambiguity was real but the fix was in the wrong file: research_subjects.reciprocal_evidence_weights is GENERIC over its member type -- run-id strings at one caller, verdict indices at the other -- and its `dict[str, float]` return was too narrow. It is a TypeVar now and both ignores are gone. Suppressing there would have hidden a false positive AND blinded the one check that would catch a real key-type mismatch in the correlated-arm discount, which CLAUDE.md 2 makes load-bearing. (2) capability_propensity.detect() came back rewritten into four locals; behaviour-preserving (verified: same objects mutated, same key insertion order) but one `out: dict[str, Any]` annotation does the same job, so the annotation was taken instead. (3) runtime_ac_gate's spec_path came back with `spec_dir or env.get(K, DEFAULT)` split into branches, which silently falls back to DEFAULT where the original raised TypeError on Path(None). Unreachable via os.environ, but this is a GATE and 'silently use a default' is the permissive direction; with env typed as Mapping[str, Any] the original one-liner type-checks unchanged, so the restructure bought nothing. Asserts added in production paths were each checked against their invariant rather than trusted: dispatcher's `profile_attempt_id is not None` sits inside `elif selected_profile:` where line 815 makes it non-None by construction, and attach_profile_attempt_to_decision already declares `decision_id: str`. LOWERED 7 -> 1 on 2026-08-24 (batch 6c): capabilities (14 findings, ONE missing annotation on KNOWN_GATES caused all of them), router (16), and the last five findings across feedback/runtime_ac/capability_outcome_bridge/capability_compiler. 98 of 99 modules now checked; only capability_advisor (24) remains, held back because PR #113 edits the same file. The drain added ZERO net type: ignore -- router's one remaining suppression predates this work. THE DRAIN FOUND A REAL BUG and the value is in how it was handled: router's load_backlog promised a bare-list payload in its own docstring and could never read one, because `.get` on a list raises AttributeError into a broad `except` that returns [] -- so a populated backlog read as NO WORK. The offloaded agent was told to report suspected real bugs rather than fix them, did exactly that, and left a type: ignore documenting it; the fix landed here instead, with a selftest asserting a non-empty list survives (an empty one cannot distinguish the fix from the failure, since [] is also what a parse error returns) and a break->revert showing the old one-liner returning [] for a valid backlog. Latent, not live: the file on disk is the {\"items\": [...]} dict form, whose behaviour including its no-items fallback is unchanged. Worth closing anyway -- the day discovery writes the documented shape the symptom would be silence, which is this repo's signature failure.", - "mypy_exempt_max": 1 + "note": "Recorded by verify.py --update-floor, except the *_max ceilings, which are edited BY HAND and never re-measured. `collected` catches tests that stopped being collected; `passed` is compared against passed+skipped, so a check may move between passing and consciously-skipped but the two together may never shrink. The *_max ceilings bound the skipped side: 24/7/2 is exactly what a machine with none of this instance's local prerequisites skips (a GitHub runner: no agent CLIs, no ~/.codex/skills, no /Applications/ChatGPT.app, no populated capability ledger), measured 2026-08-21. On the owner's machine all prerequisites exist and nothing skips at all. Raising a ceiling is a deliberate act: it means agreeing that one more thing is allowed to go unchecked, so say which and why in the commit. LOWERED 26 -> 24 on 2026-08-22, reverting the raise made earlier the same day. The two kill-switch exemption tests no longer need to skip on a bare runner: their declarations moved out of the running instance's ledger and into capabilities.KNOWN_DECLARATIONS, so they assert code-derived truth and run everywhere. Moving a test back below the ceiling is the preferred way to lower it -- fix what made it machine-dependent, rather than agreeing to check less. FLOOR 345 -> 353 on 2026-08-22: 345 was measured on a branch cut before #13 (research panels/rounds/domain studies) merged, so the recorded floor sat 8 tests BELOW what main actually collects. A floor below reality is the permissive direction -- those 8 could have silently stopped being collected and still cleared the check, which is exactly the hole this file exists to close. Measure the floor on the merge result, not on the branch. Raised again on 2026-08-22 by the producer-identity-scope branch, which adds tests on top of the 353 recorded by #15; re-measured after rebasing rather than assumed. NOTE: `verify.py --update-floor` REPLACES this note with a generic one, so it must be restored by hand after every use \u2014 the ceiling rationale is the only record of which prerequisite justifies each skip. FLOOR 365 -> 366 on 2026-08-22 (heartbeat-ordering work, PR #18): exactly one new test, test_capabilities.test_no_tick_producer_runs_above_the_heartbeat_export. No ceiling moved and nothing new is skipped -- it reads source files rather than a populated ledger, so it runs on any machine. The branch recorded 354 because it was cut before #16 merged; re-measured on the MERGE RESULT per the rule above, which is exactly the mistake that put the floor 8 below reality last time. FLOOR 366 -> 368 on 2026-08-23: main collected 368 while this file recorded 366, drift left by #34 (evidence-acquisition landed, +1) and #37 (tick capability evidence, +1) whose authors each measured against a branch cut before the other merged. A floor BELOW reality is the permissive direction this file exists to close -- those two could have silently stopped being collected and still cleared the check. Measured on the merge result per the rule above: 368 passed, 0 failed, 0 skipped, 83/83 selftests, 43/43 can-fire, 5/5 gates. CEILING 24 -> 26 and FLOOR 368 -> 387 on 2026-08-23 (profiles/provenance branch, PR #42). This file CONFLICTED with #50, which raised the floor 366 -> 368 on main while this branch raised it to 387; resolved as the UNION rather than by taking a side -- #50's rationale is retained above and the count was RE-MEASURED on the new merge result instead of keeping either number. 368 (main) + 19 (this branch's net new tests) = 387; #50 corrected recorded drift rather than adding coverage, which is why 387 is unchanged from the pre-conflict measurement. Measured in a runner sandbox reproducing CI exactly (361 passed, 26 skipped, 387 collected) AND on the owner's machine (387 passed, 0 skipped, 5/5 gates). The two new skips are drift detectors against a REAL installed agent runtime, so neither can be moved below the ceiling -- the preferred way to lower one: (1) agy advertised-models cache absent, since comparing declared model ids against the catalogue agy actually advertises needs that catalogue, and a fixture would exercise the comparison while detecting no real drift; (2) vibe config absent (~/.vibe/config.toml), since active_model cannot be read to check for drift when there is no config to read. Both name their missing prerequisite, so a green run still states what it did not check. A third candidate skip was REFUSED: dispatcher's per-run agy-log assertion failed on a bare runner because adapters.advertised_models shells out to `agy models` when its disk cache is cold, and that probe landed inside a monkeypatched subprocess.run and overwrote the captured command. That is a stub leak, so it was fixed by ISOLATING the double rather than by skipping -- which makes CI run MORE. FLOOR 387 -> 391 on 2026-08-23 (improvement-log accessor, PR #59): exactly four new tests, all in test_improvement_log.py -- three read tracked files in the tree (the pointer's size and content, and that CLAUDE.md 0 step 3 and 5 name the accessor rather than a bare path) and one runs the accessor as a subprocess against a path that cannot exist. None reads a populated ledger, an agent CLI or ~/.codex, so all four RUN on a bare runner and NO ceiling moved: nothing new is skipped. Measured on the MERGE RESULT after rebasing onto origin/main af6654d, which collected 387 -- not on the branch base, per the rule above. FLOOR 391 -> 402 on 2026-08-23 (Gate python-ci configuration, the PR that adds the missing .github/workflows/autofix-versions.env): exactly 11 new tests, all in test_ci_gate_config.py, which read committed files only -- the pin file, ruff.toml, mypy.ini, pr-00-gate.yml's toggle annotations and docs/CI_LINT_BASELINE.md. NO ceiling moved. On any CHECKOUT -- CI, the owner's tree, a second instance -- all 11 run: they need no installed linter and no populated ledger. In the EXEC-MIRROR layout all 11 skip with one named reason, because orch-sync-mirror.sh copies root-level *.py only, so .github/workflows, docs/ and scripts/ are genuinely absent there (env_prereq.repo_files_absent). That lands at 11/26 on a machine that otherwise skips nothing, and CI stays at 26/26, so no ceiling needed raising. The skip gate is the presence of those DIRECTORIES, never of the pin file itself -- gating on the file would have made the test that checks for it unable to fail. Measured on the merge result, twice: the branch was rebuilt on origin/main after #42 and #59 merged, and re-measured after #61 merged and was merged in -- 393 passed + 9 skipped = 402 collected both times, so #61 added no collected tests and this floor is not sitting below reality. #61 itself left main's floor at 391, which is exactly main-without-these-11, so there is no inherited drift to correct. RULE CHANGE 2026-08-23: `collected` is now an EQUALITY, not a minimum. Every floor entry above this one records the number being found BELOW reality and hand-raised after the fact -- 21 low at the worst, then 8, then 1, then 2 -- because nothing ever required a test-adding PR to touch this file, so the permissive direction was silent by construction and the rule 'measure on the merge result' had to be restated three times with nothing enforcing it. verify.py now FAILS when collected exceeds the floor, printing the two integers to write. That also makes the concurrency case self-enforcing: once every test-adding branch must edit these same two lines, two concurrent branches CONFLICT IN GIT, so the second cannot merge without rebasing onto the first and re-measuring on the actual merge result. Demonstrated repeatedly on the change itself: six merges landed on main in the two hours it took to write, moving this file 368 -> 387 -> 391 -> 402, and every one would have left the floor below reality under the old one-directional rule. `passed` deliberately stays a MINIMUM on passed+skipped: only collection is machine-invariant (a skipped test is still collected), measured across machines at 391 collected on both, with pass/skip splits of 365/26 on CI against 391/0 locally. The *_max ceilings are untouched by this change and nothing new is skipped. `--update-floor` also stops REPLACING this note -- it appends -- so the warning above about restoring it by hand no longer applies; and drift does NOT block --update-floor, since a gate that forbade its own only remedy would be a deadlock (the first draft was exactly that). FLOOR 402 -> 407 on 2026-08-23 (findability admission requirement). (findability admission requirement). (findability admission requirement). (findability admission requirement). Exactly five new pytest tests, all in test_capability_admission.py: test_findability_distinguishes_its_three_sub_causes, test_findability_blocks_new_capabilities_and_reports_older_ones_as_debt, test_unreadable_reach_is_not_evaluated_and_never_a_failure, test_findability_exemption_is_declared_in_code_not_in_a_live_ledger, test_consult_sites_are_falsifiable_claims_about_real_callers. NO CEILING MOVED and nothing new skips: all five build synthetic ledgers in a tempdir or read committed tables, so none needs a populated capability ledger, an agent CLI or ~/.claude/skills. The one machine-dependent thing they touch -- an external consult site declared in capability_advisor.CONSULT_SITES whose skill prompt is not on this machine -- is reported as UNVERIFIED rather than skipped, because absence of the caller is not refutation of the claim; the in-tree site (tick) is asserted verified on every machine so the check can never degrade into 'everything unverified, nothing tested'. Measured on the merge result per the rule above: this file CONFLICTED three times while the branch was open, as main went 387 -> 391 -> 402 (#61, #64, #65, #60). Each time it was resolved as the UNION rather than by taking a side, and the count was RE-MEASURED on the new merge result rather than either number being carried forward: 402 (main at bd6da2e) + 5 (this branch's new tests) = 407. That is the rule this file already states -- measure the floor on the merge result, not on the branch -- and it mattered here, because #60 both deleted test_ci_gate_config.py and added more than it removed, so guessing in either direction would have been wrong. -> re-measured on 2026-08-23 (PR #62, the four deferred #42 review findings): three new tests, all machine-independent (each builds its own tmp_path Brain and manifests), so NO CEILING MOVED and nothing new is skipped. Fourth conflict for this branch, and the first one under the EQUALITY -- which is the point: the equality's own rationale says git conflict detection is what enforces 'measure on the merge result', and that is exactly what happened here. Under the old minimum the three earlier conflicts could each have been resolved by keeping the larger number; under the equality the count MUST be measured, and it was. RESOLVED AGAINST #68 (findability admission requirement) on 2026-08-23: taken as the UNION per the rule this file states -- #68's five-test entry is retained above and this branch's three-test entry beside it -- and the count RE-MEASURED on the merge result rather than keeping either side's number. main fc1fd42 collects 407; this branch adds 3; 410 measured with `pytest --collect-only -q` on the merge result, not assumed. Ceilings untouched at 26/7/2 and nothing new is skipped. Also resolved in the same merge: langsmith-fleet-worker-attempt.json, a CI-emitted `langsmith-fleet/v1` worker-attempt record whose two sides differed only in `emitted_at` and `pr_number` (62 here, 68 on main). Main's NEWER record was kept rather than this branch's older one -- discarding a newer provenance observation to win a merge would corrupt exactly the causal-provenance evidence CLAUDE.md 2 protects, and this branch's own run re-emits its record anyway. FLOOR 410 -> 411 on 2026-08-23 (CodeRabbit follow-up on PR #42, thread 3837879039; re-measured again after #56 made `collected` an EQUALITY, which makes an assumed number a hard RED rather than a quiet pass -- main stayed at 402 across #56, and the merge result measures 403, so #56 added no collected tests and this is main's 402 plus this branch's one): exactly one new test, test_feedback_model_provenance.test_late_sweep_completes_terminal_attempts_never_one_in_flight, which pins that ledger_reconcile.resolve_unresolved_worker_attempts completes only TERMINAL unresolved worker attempts and never one still in flight. No ceiling moved and nothing new is skipped -- the test builds its own tmp ledger and codex rollout fixture and monkeypatches adapters.CODEX_SESSIONS, so it needs no agent CLI and no populated capability ledger and runs on a bare runner. RESOLVED AGAINST #59 (improvement-log accessor), which raised the floor 387 -> 391 on main while this branch raised it to 388: taken as the UNION -- #59's rationale is retained above and the count was RE-MEASURED on the new merge result rather than keeping either number, which is the rule this file states and the mistake that once put the floor 8 below reality. 391 (main, incl. #59's four tests) + 1 (this branch's one new test) = 392 measured, not assumed: 392 passed, 0 failed, 0 skipped, 83/83 selftests, 43/43 can-fire, 5/5 gates. Three sibling follow-up branches are in flight against this same main (CI/ruff config, arm-attribution + durability, adapters label->ID); if this file conflicts with one of them, resolve as the UNION and RE-MEASURE on the new merge result rather than taking either number -- that is what #42 and #50 did, and taking a side is what put the floor 8 below reality earlier. RESOLVED AGAINST #68 (findability admission requirement) on 2026-08-23: taken as the UNION per the rule this file states -- #68's five-test entry is retained above and this branch's one-test entry beside it -- and the count RE-MEASURED on the merge result. main fc1fd42 collects 407; this branch adds 1; 408 measured with `pytest --collect-only -q` on the merge result, not assumed. Ceilings untouched at 26/7/2 and nothing new is skipped -- the one new test builds its own tmp ledger and codex rollout fixture, so it runs on a bare runner. Also resolved in the same merge: langsmith-fleet-worker-attempt.json, a CI-emitted `langsmith-fleet/v1` worker-attempt record differing only in `emitted_at` and `pr_number`; main's NEWER record was kept, since discarding a newer provenance observation to win a merge would corrupt the causal-provenance evidence CLAUDE.md 2 protects. FLOOR 411 -> 415 on 2026-08-23 (PR #70 diagnostics salvage): four new collected tests in test_capability_set_coverage.py from the PR #43 salvage plus CodeRabbit follow-ups on PR #51/#70 \u2014 union/missing-candidate fetch command, truncation after six modules, AST-scoped gate-call audit, and entrypoint-diagnosis coverage. NO CEILING MOVED and nothing new is skipped; all inject synthetic ledgers or read committed source. Measured on the merge result at 91d37fa: 389 passed + 26 skipped = 415 collected on CI, not assumed. FLOOR 415 -> 416 on 2026-08-23 (the dangling-citation follow-up, PR #74): exactly ONE new test, test_ci_gate_config.test_every_cited_repo_path_resolves, which reads the two committed config files this repo OWNS (the pin file and ruff.toml) and asserts every repo-relative path they cite exists. It exists because the pin file shipped citing docs/ci/LINT_BASELINE.md when the real path was docs/CI_LINT_BASELINE.md: the sibling checks read that file's CONTENTS thoroughly and its PROSE not at all, and the prose is the only pointer telling a reader where to re-measure before bumping a pin. Scoped to the two owned files deliberately -- scanning pr-00-gate.yml yields six findings that are all correct as written (guarded by hashFiles or a .agents check, or upstream paths), and a test that cries wolf gets waived. NO ceiling moved. RE-MEASURED SIX TIMES as the base moved under this ONE-LINE change: bd6da2e 402 -> ddb0928 402 -> fc1fd42 407 -> 0d661e3 407 -> 0593eeb 411 -> 6fed4ad 415, each +1 with this test, and the branch was rebuilt on each rather than the number carried forward. THIS BRANCH IS THE WORKED EXAMPLE of the equality's concurrency cost, so record it rather than rediscover it: main moved EIGHT times in the ~2.5 hours a one-line comment fix was open (#56, #68, #73, #69, #62, #70 and two direct commits), the floor line conflicted THREE separate times, and two merges overlapped the change directly -- #73 landed a byte-identical copy of the backplane-conformance.yml guard this branch also carried (dropped as redundant), and #69 edited this very test file in a neighbouring region. The equality is still the right call and should stay: every entry above this one records the floor being found BELOW reality, which is the permissive direction. But no amount of author care wins this race, because the correct value is only knowable on the merge result. The durable fix is CI running `verify.py --update-floor` on the merge commit, which keeps the equality and removes the race; until then a test-adding PR must be merged promptly after going green, because it re-conflicts on roughly every subsequent merge. FLOOR 416 -> 427 on 2026-08-23 (PR #72 hygiene untrack, rebased after #71 merged): exactly 11 new tests from test_repo_artifact_hygiene.py with root-anchored gitignore patterns. NO ceiling moved. Measured on merge result after #71 landed on main: 416 (main) + 11 = 427 collected via pytest --collect-only -q, not assumed. #71's simpler untrack landed first; this branch carries the full hygiene test suite and corrected root-anchored patterns. FLOOR 427 -> 428 on 2026-08-23 (PR salvaging #34/#42 remnants): exactly one new test, test_feedback_model_provenance.test_gemini_provenance_reads_the_per_run_log_before_the_conversation_store, recovered from #42's post-merge commit 4e0d6ae along with the adapters catalog work it exercises. No ceiling moved and nothing new is skipped -- it seeds adapters._ADVERTISED_MEMO instead of letting the catalog probe shell out, so it runs on any machine and adds no prerequisite. `passed` is 428 rather than the 426 verify.py suggested on this machine: two test_capabilities liveness tests (test_gate_blocks_execution_is_opt_in_and_narrow, test_evidence_gate_kind_is_not_blanket_observer) currently fail HERE on pristine main as well, because the hourly fleet tick mutated the machine-local ledger and range-lane-rollout now classifies matched_not_invoked rather than deliberately_gated. That is ledger STATE, not this branch and not the code -- CI bootstraps an empty ledger and counts 428/428. Recording 426 would have baked a local environment failure into the floor as though it were the expected result. FLOOR 428 -> 441 on 2026-08-23 (coverage measures what actually runs): exactly 12 new tests, all in test_verify_coverage_mode.py. They read committed files and verify.py's own source, and monkeypatch verify.COVERAGE in-process -- no populated ledger, no agent CLI, no ~/.codex, and no coverage RUN -- so all 12 execute on any machine and NO ceiling moved. The change itself is a measurement fix, not a gate: `verify.py --coverage` wraps each child in `coverage run --parallel-mode` and combines, because the per-module --selftest is a SUBPROCESS and a pytest-only coverage run cannot see it. That blind spot was most of the codebase -- 78 modules have no test_*.py at all, ~85,500 lines, 79.6% of non-test root Python -- so the reported 48.45% was measuring the gap in the instrument, not a gap in the tests. Combined: 76.1% (45,049 statements, 10,774 missed). Twelve of the twelve modules the old report named as worst were selftest-only; outcomes.py reported 9.0% and measures 61.9%, watch.py 9.6% -> 86.9%. Coverage is OFF by default and deliberately never touches the exit code -- one of the 12 tests pins that, because enforcing a threshold here would reward pytest wrappers around already-tested modules: metric up, assurance flat. Measured on the MERGE RESULT: branched from origin/main bcc68cd (floor 427), then REBASED onto f5f1c39 when it landed underneath and re-measured on the new merge result rather than carrying the old number: 428 + 13 = 441. +1 on 2026-08-23 (440 -> 441 after the rebase), same branch: test_the_cli_help_actually_renders. It exists because this branch BROKE `verify.py --help` and its own twelve tests did not notice. argparse interpolates help strings with `% params`, so the literal `~80%` in the --coverage help was read as an `%o` octal conversion and --help died with 'badly formed help string'. All twelve original tests passed: every one inspected source text or monkeypatched a flag, and not one RENDERED the help -- a construction-time test suite that never exercised the constructed thing, which is this repo's founding defect one layer up. CI's verify.py gate caught it, which is the check of last resort working as intended. The new test runs `verify.py --help` as a subprocess and asserts it exits 0, so it runs anywhere and NO ceiling moved. Rendering rather than grepping for `%` is deliberate: a grep would flag the legitimate `%(default)s`. FLOOR 441 -> 442 on 2026-08-23 (matched_not_invoked yields to observers and declared gates): exactly one new test, test_capabilities.test_matched_not_invoked_yields_to_observers_and_declared_gates. It is SYNTHETIC on purpose and that is the point of it: the two tests that caught this bug in the wild read the LIVE ledger, so they skipped with a named reason on the empty ledger ci.yml bootstraps -- the defect was red on every populated machine and green on CI for as long as it existed. A synthetic row asks the same question everywhere, so this one RUNS on a bare runner and NO ceiling moved. The fix itself moves matched_not_invoked below `observing` and below the DECLARED deliberately_gated check in classify_liveness: it was the first check, which made it the fourth instance of the unescapable label the comments in that function exist to fix. Audited before committing -- 12 of 43 live rows reclassify (ten observers to observing, two declared gates to deliberately_gated) and ZERO move for any other reason, so nothing is reclassified by inference and the weaker gate_reason-only branch is untouched. Measured on origin/main 0d9c3a7, whose recorded floor is 441, so 441 + 1 = 442. FLOOR RECORDED by verify.py --update-floor on 2026-08-23: collected=442, passed=442. Ceilings preserved, never re-measured \u2014 they are edited by hand. FLOOR RECORDED by verify.py --update-floor on 2026-08-24: collected=442, passed=442. Ceilings preserved, never re-measured \u2014 they are edited by hand. FLOOR RECORDED by verify.py --update-floor on 2026-08-24: collected=442, passed=442. Ceilings preserved, never re-measured \u2014 they are edited by hand. MYPY_EXEMPT_MAX introduced at 64 on 2026-08-23, the same change that flipped `typecheck` ON in pr-00-gate.yml. It was OFF because 608 whole-tree errors were drainable 0 per PR -- a gate whose clear path is blocked by the thing it measures. Two real changes opened it: the src/ move scoped the Gate's `target=src` to the 99 modules (608 -> 467), and pyproject.toml's [[tool.mypy.overrides]] exempts the modules that still have findings BY NAME so the 35 already-clean ones are checked today. 12 var-annotated findings were then drained (467 -> 455, 66 -> 64 modules) to prove the drain works rather than promise it. This ceiling may only ever be LOWERED, by typing a module and deleting its line -- raising it means agreeing one more module goes unchecked, so say which and why. NOT a suppression: no error code is disabled anywhere and the 455 stay visible via `python3 scripts/ci_lint_baseline.py`. Edited BY HAND like the other *_max values; --update-floor never re-measures it. MYPY_EXEMPT_MAX LOWERED 64 -> 43 on 2026-08-24, the ratchet's first real drain: 21 modules typed clean and removed from the exempt list, 455 -> 430 findings. Targeted the modules with 1-3 errors on purpose -- fixing 50 errors spread across the big modules would move this number by ZERO, and this number is what the gate reads. Lowering it is the drain; it may never be raised without naming the module and why. MYPY_EXEMPT_MAX LOWERED 43 -> 33 on 2026-08-24 (batch 2 of the drain): the whole <=5-finding tail typed clean. 66 of 99 modules now checked. What remains is five per-module campaigns (capability_advisor, dispatcher, capability_propensity, runtime_ac_gate, capabilities hold most of it), so future batches take ONE big module at a time rather than skimming. (batch 2 detail: 43 -> 26, 430 -> 374 findings, 73 of 99 modules checked. `mypy_path` gained `tests` so mypy can RESOLVE the recurrence-fixture roster capability_admission legitimately imports; the target stays `src`, but mypy then follows into that one test file, whose two findings were fixed rather than configured around.) MYPY_EXEMPT_MAX LOWERED 26 -> 20 on 2026-08-24 (batch 3): 79 of 99 modules checked. FLOOR 442 -> 448 on 2026-08-24 (absent-check detector + its ratchet): SIX new tests in tests/test_checks_reported.py holding the frequency rule and the expected-check ratchet. NO ceiling moved -- they call pure functions and read one committed JSON file, so they run on any machine. The ratchet exists because dogfooding the detector caught it DISARMING ITSELF: while pr-00-gate.yml sat held, every merged PR merged without the Gate, so after twelve such merges the Gate's checks fell below the 75% frequency threshold, the expected set eroded 23 -> 14, and PR #91 was pronounced clean by the tool written to catch exactly that. config/expected-checks.json is the high-water mark, seeded from PRs #87/#89 whose Gate demonstrably ran, and it only comes down when somebody deletes a line. LOWERED to 16 on 2026-08-24 (batch 4, re-applied after merging main, which carried #94/#100's own floor work \u2014 main's note kept, only the bound re-set). LOWERED 16 -> 16 on 2026-08-24 (batch 5): 83 of 99 checked. LOWERED 16 -> 12 on 2026-08-24 (batch 5): 87 of 99 checked. Lesson recorded three times now: measure with the PROJECT run, never per-file \u2014 `mypy src/X.py` reports clean for modules the project run still flags. FLOOR 448 -> 450 on 2026-08-24 (giving the per-node deliberate-break finding its consumers): exactly two new pytest tests, both in test_synthesis_promotion.py -- test_a_passing_break_names_the_tautologies_it_carried and test_the_break_caveat_is_silent_on_clean_and_on_pre_per_node_evidence. NO CEILING MOVED and nothing new is skipped: the first builds its own git repo in tmp_path and runs the real verification path (git + pytest only, no populated ledger, no agent CLI, no ~/.codex), and the second is a pure unit on _break_caveat. The third piece of this change is a runtime_ac selftest case, which adds NO collected test -- runtime_ac has a --selftest and synthesis_promotion does not, which is the whole reason only one of the two needed pytest tests. Measured on the merge result: branched from origin/main 8549f84, whose recorded floor is 448, and re-checked that main had not moved before writing this. 448 + 2 = 450, from verify.py's own count (450 passed, 0 failed, 0 skipped, 85/85 selftests, 5/5 gates), not assumed. FLOOR 448 -> 451 on 2026-08-24 (offload guidance correction, PR #113): THREE new tests in test_repo_artifact_hygiene.py -- two parametrized entries adding src/UNKNOWN.egg-info/PKG-INFO and UNKNOWN.egg-info/PKG-INFO to EMITTED_ARTIFACTS, and test_no_build_metadata_is_tracked. NO ceiling moved and nothing new skips: all three shell out to git against this checkout, so they run anywhere git does. They exist because THIS PR carried four committed build artifacts and no check objected. A CI step runs `pip install -e .`, setuptools writes src/UNKNOWN.egg-info/ (named UNKNOWN because pyproject.toml declares no [project] on purpose), and the repo's own autofix bot committed all four -- .gitignore had no *.egg-info/ entry and this suite only knew the langsmith-fleet family. CodeRabbit caught it; nothing local did. Both locations are listed because a checkout builds into src/ while the EXEC MIRROR IS FLAT. The tracked test is separate from the ignored test on purpose: the four files were committed BEFORE the pattern existed, and adding a pattern does nothing to a path git already tracks -- so an ignore-only check passes on a repo still carrying the debris. RESOLVED AGAINST #110 and #114 on 2026-08-24, which moved main 448 -> 450 while this branch raised it to 451: taken as the UNION per the rule this file states -- main's entries are retained above and this branch's three-test entry beside them -- and the count RE-MEASURED on the merge result rather than either number being carried forward. 450 (main) + 3 (this branch) = 453, measured with `pytest --collect-only -q`, not assumed. Ceilings untouched and nothing new is skipped. FLOOR 453 -> 458 on 2026-08-24 (untracking .coverage, the coverage database this repo's own verify.py writes): exactly FIVE new tests, all in test_repo_artifact_hygiene.py -- two parametrized ignore cases over COVERAGE_DATA_FILES (.coverage and a parallel-mode .coverage...), one untracked case, and two parametrized must-stay-committable cases (.coveragerc, tools/coverage_guard.py). NO CEILING MOVED and nothing new is skipped: all five ask GIT about a path in this checkout (check-ignore / ls-files) and need no populated ledger, no agent CLI and no ~/.codex, so all five RUN on a bare runner. The change is `git rm --cached .coverage` plus root-anchored `/.coverage` and `/.coverage.*`; the 90 KB SQLite database arrived on main in #109, a typing PR whose every other file is about mypy, and verify.py's coverage_reset() unlinks it and coverage_combine_and_report() rewrites it on every --coverage run -- so while tracked it was an opaque binary rewritten by the command that produces this repo's verdict. Both patterns because two different steps write them, and `/.coverage.*` rather than `/.coverage*` because the second swallows .coveragerc. Break -> revert performed in all three directions and recorded in the test file. Measured on the MERGE RESULT: fast-forwarded onto origin/main 5c769e0, whose recorded floor is 453, and re-fetched to confirm main had not moved again before measuring. 453 + 5 = 458 from verify.py's own count (458 passed, 0 failed, 0 skipped, 85/85 selftests, 5/5 gates), not assumed. LOWERED 12 -> 10 on 2026-08-24 (batch 6): keepalive_outcomes (17 findings) and redirect_sweep (18) typed clean, 89 of 99 modules checked, 240 -> 205 findings. Both modules were drained by WRITE-MODE isolated offloads (dispatcher.offload --isolate) rather than in-seat, and every diff was reviewed here before it was applied -- the two changes that could have altered behaviour were checked first-person and both are equivalent: redirect_sweep's marker-rc read keeps the same except clause wrapping it, so a non-numeric rc still raises inside the try and still lands at None; keepalive_outcomes' added `oc is not None` guard short-circuits ahead of _should_record_outcome, whose own first line already returns False on oc is None. LOWERED 10 -> 7 on 2026-08-24 (batch 6b): dispatcher (65 findings), capability_propensity (47) and runtime_ac_gate (34) typed clean, 92 of 99 modules checked, 205 -> 91 findings. All three drained by write-mode isolated offloads and then INTEGRATED BY HAND rather than applied as returned -- three of the agents' choices were replaced with smaller ones, and the reasons are the durable part. (1) capability_propensity came back with two `type: ignore`s at the correlated-arm lookup, justified as an ambiguous key type. The ambiguity was real but the fix was in the wrong file: research_subjects.reciprocal_evidence_weights is GENERIC over its member type -- run-id strings at one caller, verdict indices at the other -- and its `dict[str, float]` return was too narrow. It is a TypeVar now and both ignores are gone. Suppressing there would have hidden a false positive AND blinded the one check that would catch a real key-type mismatch in the correlated-arm discount, which CLAUDE.md 2 makes load-bearing. (2) capability_propensity.detect() came back rewritten into four locals; behaviour-preserving (verified: same objects mutated, same key insertion order) but one `out: dict[str, Any]` annotation does the same job, so the annotation was taken instead. (3) runtime_ac_gate's spec_path came back with `spec_dir or env.get(K, DEFAULT)` split into branches, which silently falls back to DEFAULT where the original raised TypeError on Path(None). Unreachable via os.environ, but this is a GATE and 'silently use a default' is the permissive direction; with env typed as Mapping[str, Any] the original one-liner type-checks unchanged, so the restructure bought nothing. Asserts added in production paths were each checked against their invariant rather than trusted: dispatcher's `profile_attempt_id is not None` sits inside `elif selected_profile:` where line 815 makes it non-None by construction, and attach_profile_attempt_to_decision already declares `decision_id: str`. LOWERED 7 -> 1 on 2026-08-24 (batch 6c): capabilities (14 findings, ONE missing annotation on KNOWN_GATES caused all of them), router (16), and the last five findings across feedback/runtime_ac/capability_outcome_bridge/capability_compiler. 98 of 99 modules now checked; only capability_advisor (24) remains, held back because PR #113 edits the same file. The drain added ZERO net type: ignore -- router's one remaining suppression predates this work. THE DRAIN FOUND A REAL BUG and the value is in how it was handled: router's load_backlog promised a bare-list payload in its own docstring and could never read one, because `.get` on a list raises AttributeError into a broad `except` that returns [] -- so a populated backlog read as NO WORK. The offloaded agent was told to report suspected real bugs rather than fix them, did exactly that, and left a type: ignore documenting it; the fix landed here instead, with a selftest asserting a non-empty list survives (an empty one cannot distinguish the fix from the failure, since [] is also what a parse error returns) and a break->revert showing the old one-liner returning [] for a valid backlog. Latent, not live: the file on disk is the {\"items\": [...]} dict form, whose behaviour including its no-items fallback is unchanged. Worth closing anyway -- the day discovery writes the documented shape the symptom would be silence, which is this repo's signature failure. LOWERED 1 -> 0 on 2026-08-24 (batch 6d, THE LAST ONE): capability_advisor's 24 findings typed, the [[tool.mypy.overrides]] block removed entirely, and all 99 of 99 modules now checked. 240 findings drained to zero across the campaign with ZERO net `# type: ignore` added. THE LAST MODULE EXPOSED A LATCHED GATE IN THE RATCHET ITSELF, which is the durable finding here. verify.mypy_exempt_modules() returned None for BOTH 'pyproject unreadable' and 'readable, no override block' -- so the run that FINISHED the drain would have printed 'mypy ratchet: NOT COUNTED', the gate going silent at the exact moment it succeeded. Its own docstring already argued against this ('a ratchet that stops being counted is indistinguishable from one that emptied, and only one of those is good news'), and two more things prove it was unintended: _format_mypy_exempt_line carried a ' -- fully drained' branch no input could reach, and the selftest asserted the function was TRUTHY, so an empty list failed it. That is the CLAUDE.md pattern exactly -- a gate whose clear path is blocked by the thing it measures -- and it would have latched on the last module. Fixed: [] now means answered-and-empty, None stays unanswerable, and the selftest asserts all three renderings plus `is not None` rather than truthiness. `collected` is unchanged at 453: the new coverage lives in verify.py's own selftest, which pytest does not collect.", + "mypy_exempt_max": 0 } diff --git a/pyproject.toml b/pyproject.toml index bc07bd2..86bea13 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -124,8 +124,3 @@ mypy_path = ["src", "tests"] # It fails toward motion, not silence: verify.py prints the remaining count every run, and # `.verify-floor.json`'s `mypy_exempt_max` FAILS if the list grows — so new untyped code in a clean # module is now a red, and a module can never quietly rejoin the exempt set. -[[tool.mypy.overrides]] -module = [ - "capability_advisor", -] -ignore_errors = true diff --git a/src/capability_advisor.py b/src/capability_advisor.py index 8e91457..18282ec 100644 --- a/src/capability_advisor.py +++ b/src/capability_advisor.py @@ -644,17 +644,17 @@ def advise( if bound: present = {m["capability_id"] for m in matched} for cap_id, reason in bound.items(): - cap = caps.get(cap_id) - if cap is None or cap.get("status") in {"retired", "superseded"}: + bound_cap: dict[str, Any] | None = caps.get(cap_id) + if bound_cap is None or bound_cap.get("status") in {"retired", "superseded"}: continue if cap_id not in present: matched.append( { "capability_id": cap_id, "matched_task_type": None, - "entrypoint": cap.get("entrypoint"), + "entrypoint": bound_cap.get("entrypoint"), "bound_only": True, - **_usability(cap), + **_usability(bound_cap), } ) unmatched.pop(cap_id, None) @@ -771,10 +771,9 @@ def should_reask(previous: dict | None, current_context: dict) -> dict: # The work reclassified — e.g. an "implement" task that has moved on to writing tests. This is # the highest-value trigger: it is exactly when a different capability becomes relevant. - now_types = set( - classify_task(str(current_context.get("task") or "")) - and [c["task_type"] for c in classify_task(str(current_context.get("task") or ""))] - ) + now_types: set[str] = { + c["task_type"] for c in classify_task(str(current_context.get("task") or "")) + } was_types = set(previous.get("task_types") or []) if now_types and now_types != was_types: reasons.append(f"task_reclassified:{','.join(sorted(now_types - was_types)) or 'narrowed'}") @@ -1549,7 +1548,7 @@ def consult_text(surface: str, day: str) -> str: def consult_phases( *, day: str | None = None, - surfaces: list[str] | None = None, + surfaces: list[Any] | None = None, record: bool = True, path=None, ) -> dict: @@ -1862,7 +1861,7 @@ def transferable_concept(capability_id: str) -> str | None: return declared or None -def consult_target(repository: str) -> str: +def consult_target(repository: str | None) -> str: """What this consult is about: `self`, `audited_repo`, or `unknown` when no repo was named.""" repo = str(repository or "").strip() if not repo: @@ -2013,7 +2012,7 @@ def evaluate_precondition( declared = applies_to(capability_id) needs = required_repo_fact(capability_id) target = consult_target(repository) - out: list[Any] = { + out: dict[str, Any] = { "applies_to": declared, "scope_target": target, "scope_match": None, @@ -3854,9 +3853,9 @@ def _selftest_findability() -> None: with tempfile.TemporaryDirectory(prefix="adv-find-") as td: ledger = Path(td) / "capabilities.json" capabilities.save({}, ledger) - site = Path(td) / "fake-skill.md" - site.write_text('consult with surface: "t-find:asked"\n') - CONSULT_SITES["t-find:asked"] = {"caller": str(site), "how": "synthetic"} + site_path = Path(td) / "fake-skill.md" + site_path.write_text('consult with surface: "t-find:asked"\n') + CONSULT_SITES["t-find:asked"] = {"caller": str(site_path), "how": "synthetic"} inv = surfaces_binding( ["wide-cap", "asked-cap", "silent-cap", "absent-cap"], path=ledger @@ -3879,7 +3878,7 @@ def _selftest_findability() -> None: # PRESENT BUT NO LONGER NAMING ITS SURFACE IS DRIFT, and drift must LEAVE `reached`. # Broken first by treating any readable file as verification, which let a renamed # surface keep counting as consulted forever. - site.write_text("this file no longer mentions the surface at all\n") + site_path.write_text("this file no longer mentions the surface at all\n") drifted = consulting_surfaces() assert "t-find:asked" not in drifted["reached"], drifted["reached"][:8] assert any(d["surface"] == "t-find:asked" for d in drifted["drifted"]), drifted diff --git a/src/repo_knowledge.py b/src/repo_knowledge.py index bd7fd46..9ea6748 100644 --- a/src/repo_knowledge.py +++ b/src/repo_knowledge.py @@ -2523,9 +2523,36 @@ def fake_gh_failure(command, **_kwargs): assert clustered[1]["cluster_key"] == "always_run_pytest_before_merging", clustered finally: p.unlink(missing_ok=True) + + # ---- MALFORMED current_refs IS REJECTED, WHATEVER SHAPE THE MALFORMATION TAKES. + # `validate_current_refs` declares `refs: list[dict]`, and its caller in capability_compiler + # used to pass `cast(dict, contract.get("current_refs") or {})` -- a cast that named the wrong + # type over a fallback of the wrong type. Harmless in practice, because a dict and an empty + # list both fail `not isinstance(refs, list) or not refs` and take the same branch, which is + # exactly why nothing noticed: the annotation was wrong and the behaviour was right. That + # coincidence is the reason to pin it rather than trust it -- the cast is now `list`/`[]`, and + # if anyone "simplifies" the isinstance guard away, a dict would start being ITERATED (yielding + # its string keys) instead of rejected. + import tempfile as _tf + + with _tf.TemporaryDirectory(prefix="rk-refs-") as _td: + # Annotated because the ratchet now checks this module: a bare heterogeneous tuple gives + # mypy nothing to infer. The shapes are deliberately mixed -- that IS the test. + _malformed: tuple[Any, ...] = ({}, {"path": "README.md"}, [], "README.md", None) + for _bad in _malformed: + _res = validate_current_refs(_td, _bad) # type: ignore[arg-type] # malformed on purpose + assert _res["valid"] is False, (_bad, _res) + assert _res["errors"] == ["current refs are required"], (_bad, _res) + assert _res["refs"] == [], (_bad, _res) + # and the well-formed shape still validates, so the assertions above are not vacuous + (Path(_td) / "README.md").write_text("x\n") + _ok = validate_current_refs(_td, [{"path": "README.md"}]) + assert _ok["valid"] is True, _ok + print( "repo_knowledge.py selftest: OK (seed, filters, prompt append, truncation, " - "snapshot/docs/review suggestions, memory search, clustering, approval)" + "snapshot/docs/review suggestions, memory search, clustering, approval, " + "malformed current_refs rejected)" ) diff --git a/src/verify.py b/src/verify.py index 7c805e8..8199e0b 100644 --- a/src/verify.py +++ b/src/verify.py @@ -532,9 +532,19 @@ def _appended_note(prior: str | None, collected: int, passed: int, today: str) - def mypy_exempt_modules() -> list[str] | None: """Modules on `[[tool.mypy.overrides]] ignore_errors` — the ratchet's blocking quantity. - None means the question could not be answered here (no pyproject.toml, unreadable, no override). - REPORTED, never treated as zero: a ratchet that stops being counted is indistinguishable from - one that emptied, and only one of those is good news. + None means the question COULD NOT BE ANSWERED (no pyproject.toml, or it does not parse). + [] means it was answered and nothing is exempt -- the drained state. REPORTED, never treated as + zero: a ratchet that stops being counted is indistinguishable from one that emptied, and only + one of those is good news. + + THOSE TWO WERE THE SAME VALUE UNTIL 2026-08-24, and the docstring above was already the argument + against it. A readable pyproject with no `ignore_errors` override returned None, so the run that + FINISHED the drain printed "NOT COUNTED" -- the gate going quiet at the exact moment it + succeeded, which is the failure this file exists to prevent. Two things prove it was unintended: + `_format_mypy_exempt_line` already carries a " -- fully drained" branch that no input could + reach, and the selftest below asserted this function was TRUTHY, so an empty list would have + failed it. A gate whose own test forbids its drained state is a latched gate (CLAUDE.md), and + this one would have latched on the last module. """ try: import tomllib @@ -546,7 +556,8 @@ def mypy_exempt_modules() -> list[str] | None: if override.get("ignore_errors"): mods = override.get("module") return sorted(mods) if isinstance(mods, list) else [str(mods)] - return None + # Readable, and nothing is exempt: ANSWERED, not unanswerable. See the docstring. + return [] def _format_mypy_exempt_line(mods: list[str] | None, limit: int | None, total: int = 99) -> str: @@ -1174,8 +1185,16 @@ def _selftest() -> None: assert _ceiling_problems({"mypy_exempt_max": 64}, {**_zero, "mypy_exempt_max": 64}) == [] _over = _ceiling_problems({"mypy_exempt_max": 64}, {**_zero, "mypy_exempt_max": 65}) assert len(_over) == 1 and "mypy_exempt_max" in _over[0], _over - # And the real file must be readable, or the line would silently report NOT COUNTED forever. - assert mypy_exempt_modules(), "pyproject.toml's ignore_errors override is unreadable" + # The three states are DISTINCT, and conflating the last two is what made this a latched gate: + # a full drain must read as "fully drained", never as "NOT COUNTED". + assert "NOT COUNTED" in _format_mypy_exempt_line(None, 0), "unanswerable must say so" + assert "fully drained" in _format_mypy_exempt_line([], 0), "an empty ratchet is the good news" + assert "1/1 max" in _format_mypy_exempt_line(["m"], 1), "a live ratchet reports both numbers" + # And the real file must PARSE -- `is not None`, not truthiness. Asserting truthiness here meant + # the ratchet's own selftest failed the moment the list emptied, i.e. the gate forbade its drain. + assert ( + mypy_exempt_modules() is not None + ), "pyproject.toml does not parse; the ratchet cannot be counted" print( "verify.py selftest: OK (count parsing, selftest discovery, silent-zero-exit is a "