Compatible sdk for devnet #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonnie57
requested review from
AndyBoWu,
DonFungible,
LeoHChen,
allenchuang,
edisonz0718 and
jacob-tucker
as code owners
bonnie57
force-pushed
the
bonnie/SDK-45
branch
from
030701f to
f627270
Compare
DracoLi
reviewed
Jan 23, 2025
| id: 15_16, | ||
| name: "odyssey", | ||
| export const devnet = defineChain({ | ||
| id: 13_15, |
Contributor
There was a problem hiding this comment.
why not just 1315 here? what's the reason we use a separator?
Collaborator
Author
There was a problem hiding this comment.
In viem, it also follows the pattern, such as sepolia. It will become more readable.
DracoLi
approved these changes
Jan 24, 2025
bonnie57
force-pushed
the
bonnie/SDK-45
branch
from
b22c040 to
7d9e6f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
disputeand other testsmaxAllowedRewardSharefieldsdefaultMintingFee,royaltyPolicy, andMintingFee.deventtohomerTest Plan
Related Issue
Compatible sdk for devnet #386
Notes