Vite: Fix pnpm support by replacing @storybook/global with window#22709
Merged
Conversation
shilman
approved these changes
May 24, 2023
shilman
changed the title
windowwindow
shilman
added
the
patch:yes
shilman
added a commit
that referenced
this pull request
May 24, 2023
Vite: Fix pnpm support by replacing @storybook/global with `window`
Merged
shilman
added
the
patch:done
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22695
What I did
If we want to use
@storybook/globalin a virtual module in the vite builder, we'd need to add it to the runtime bundle in order to support pnpm users. Since this is purely preview code, though, we can just usewindowand avoid the dep entirely.How to test
Create a pnpm project, add storybook, swap in this change, confirm that stories load. I did that in my own pnpm project and it works well now on 7.0.15.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]