Build: add discord notification when generating sandboxes fails#22638
Merged
Conversation
ndelangen
added
patch:yes
ndelangen
changed the title
shilman
pushed a commit
that referenced
this pull request
May 22, 2023
…nerate-sandboxes-fail Build: add discord notification when generating sandboxes fails
Merged
shilman
added
the
patch:done
JReinhold
reviewed
May 25, 2023
| run: yarn publish-sandboxes --remote=https://storybook-bot:${{ secrets.PAT_STORYBOOK_BOT}}@github.com/storybookjs/sandboxes.git --push --branch=next | ||
| working-directory: ./code | ||
| - name: The job has failed | ||
| if: ${{ failure() || cancelled() }} |
Contributor
There was a problem hiding this comment.
pro tip (but also very useless) @ndelangen, you don't need to wrap it in an ${{ expression }} syntax when writing if: declarations, that is automatically handled. So you could do:
if: failure() || cancelled()
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding discord notifications to the monitoring channel so we are alerted when generating sandboxes fails