Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Add support for storybook 7 #10

Closed
amurf opened this issue Feb 2, 2023 · 4 comments · Fixed by #13
Closed

Add support for storybook 7 #10

amurf opened this issue Feb 2, 2023 · 4 comments · Fixed by #13

Comments

@amurf
Copy link

amurf commented Feb 2, 2023

No next version seems to have been created for this library, which breaks our whole test suite when attempting to upgrade to storybook 7

I've had a look at the issue a little bit, and after updating addons to use a named export (#9) there is a bunch of typing changes that I can't quite figure out.

This has been done for the react equivalent repo already here storybookjs/testing-react#120 and a lot of it would be re-usable here as far as I can tell

@EwenDC
Copy link

EwenDC commented Apr 4, 2023

This package, as well as @storybook/testing-vue and @storybook/testing-angular, are currently recommended in the Storybook v7 docs despite none of them working with v7! We need some clear communication on if you plan to maintain these addons at all, as the fact that @storybook/testing-react got ported and integrated into the core API is sending mixed messages.
image

@MichaelBitard
Copy link

Is there something we can do to help @yannbf?
Sorry to ping you but it seems you are (were?) the main committer on the repo

@yannbf
Copy link
Member

yannbf commented May 9, 2023

Hey everyone! Thanks for raising this issue. Things are quite busy at the moment which makes it tough to update all of these packages, sorry about that!

I’d really love some help if anyone is up for it. the @storybook/testing-react lib has been updated and you could use it as a reference to get this library to a similar state. You can check the differences in this file and bring them to this file in this library. I’m happy to assist along the way and help get this to the finish line!

We also are going to update the documentation to reflect the current state of these packages.

Thank you so much!

@yannbf
Copy link
Member

yannbf commented Jul 24, 2023

Hey there, this is now supported in version 1.0.0 of this package. Thank you so much for your patience <3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants