From 6e309ce29cc5c14c01cf7a331fcc5daeb09e00a6 Mon Sep 17 00:00:00 2001 From: Valentin Palkovic Date: Fri, 22 May 2026 14:41:47 +0200 Subject: [PATCH 1/2] Build: Bump Node.js to 22.22.3 The Angular CLI now requires Node.js >= v22.22.3 (or v24.15.0 / v26.0.0); v22.22.1 fails Angular prerelease sandbox generation. Bump the pinned version in .nvmrc, the Angular sandbox node-version CI step, the nx.yml workflow, and AGENTS.md. Angular sandboxes run on 22.22.3 via the node/install CI step, the established mechanism for enforcing a minimum Node version regardless of the base image. The CircleCI executor base image is intentionally left on cimg/node:22.22.1 -- switching it to cimg/node:22.22.3 broke oxc-parser resolution during sandbox creation across all CI jobs. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/nx.yml | 2 +- .nvmrc | 2 +- AGENTS.md | 2 +- code/lib/cli-storybook/src/sandbox-templates.ts | 2 +- scripts/ci/sandboxes.ts | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/nx.yml b/.github/workflows/nx.yml index 8afa8c14b353..05641df64c5a 100644 --- a/.github/workflows/nx.yml +++ b/.github/workflows/nx.yml @@ -84,7 +84,7 @@ jobs: }); - uses: actions/setup-node@v4 with: - node-version: 22 + node-version-file: '.nvmrc' cache: 'yarn' - run: yarn install --immutable - uses: nrwl/nx-set-shas@v4 diff --git a/.nvmrc b/.nvmrc index ddeb00c1678b..cde04c9af5a2 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1,2 +1,2 @@ -22.22.1 +22.22.3 diff --git a/AGENTS.md b/AGENTS.md index c805a77786ba..8f1660113802 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -9,7 +9,7 @@ This file is the canonical instruction source for coding agents. Files like `CLA Storybook is a large TypeScript monorepo. The git root is the repo root, the main code lives in `code/`, and build tooling lives in `scripts/`. The default branch is `next`. - **Base branch**: `next` (all PRs should target `next`, not `main`) -- **Node.js**: `22.22.1` (see `.nvmrc`) — supports `.ts` natively via type stripping (no loader needed) +- **Node.js**: `22.22.3` (see `.nvmrc`) — supports `.ts` natively via type stripping (no loader needed) - **Package Manager**: Yarn Berry - **Task orchestration**: NX plus the custom `yarn task` runner - **CI environment**: Linux and Windows diff --git a/code/lib/cli-storybook/src/sandbox-templates.ts b/code/lib/cli-storybook/src/sandbox-templates.ts index dcd313b0db00..79fde0601dcc 100644 --- a/code/lib/cli-storybook/src/sandbox-templates.ts +++ b/code/lib/cli-storybook/src/sandbox-templates.ts @@ -98,7 +98,7 @@ export type Template = { }; /** Additional CI steps in case this template has special needs during CI. */ extraCiSteps?: { - // Some sandboxes (e.g. Angular) rely on Node 22.22.1 as minimum supported version and threfore it needs enforcing, even if the CI image comes with a different node version. + // Some sandboxes (e.g. Angular) rely on Node 22.22.3 as minimum supported version and threfore it needs enforcing, even if the CI image comes with a different node version. ensureMinNodeVersion?: boolean; }; /** Additional options to pass to the initiate command when initializing Storybook. */ diff --git a/scripts/ci/sandboxes.ts b/scripts/ci/sandboxes.ts index 8f86dc60b391..e2c3caabc393 100644 --- a/scripts/ci/sandboxes.ts +++ b/scripts/ci/sandboxes.ts @@ -26,8 +26,8 @@ function getSandboxSetupSteps(template: string) { extraSteps.push({ 'node/install': { 'install-yarn': true, - // Currently using Node 22.22.1 as minimum supported version for Angular sandboxes - 'node-version': '22.22.1', + // Currently using Node 22.22.3 as minimum supported version for Angular sandboxes + 'node-version': '22.22.3', }, }); } From c095ea43b782c61a9dcbc8fc561e4ec6fd46ec2a Mon Sep 17 00:00:00 2001 From: Valentin Palkovic Date: Wed, 27 May 2026 12:32:27 +0200 Subject: [PATCH 2/2] Apply suggestion from @valentinpalkovic --- AGENTS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AGENTS.md b/AGENTS.md index 8f1660113802..e9066b8bb45c 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -9,7 +9,7 @@ This file is the canonical instruction source for coding agents. Files like `CLA Storybook is a large TypeScript monorepo. The git root is the repo root, the main code lives in `code/`, and build tooling lives in `scripts/`. The default branch is `next`. - **Base branch**: `next` (all PRs should target `next`, not `main`) -- **Node.js**: `22.22.3` (see `.nvmrc`) — supports `.ts` natively via type stripping (no loader needed) +- **Node.js**: `22.12+` (see `.nvmrc`) — supports `.ts` natively via type stripping (no loader needed) - **Package Manager**: Yarn Berry - **Task orchestration**: NX plus the custom `yarn task` runner - **CI environment**: Linux and Windows