Addon-Vitest: Update Vitest plugin configuration to disable requireAssertions for expect#33693
Merged
Merged
Conversation
…sertions for expect
|
View your CI Pipeline Execution ↗ for commit d33b9c3
☁️ Nx Cloud last updated this comment at |
Contributor
📝 WalkthroughWalkthroughA Vitest configuration property is added to the plugin, setting Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing touches
Comment |
JReinhold
approved these changes
Jan 28, 2026
24 tasks
8 tasks
Merged
10 tasks
valentinpalkovic
added a commit
that referenced
this pull request
Jan 30, 2026
…ireassertions Addon-Vitest: Update Vitest plugin configuration to disable requireAssertions for expect (cherry picked from commit b18d12e)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33692
What I did
SvelteKit's default Vitest configuration sets expect.requireAssertions: true. When using addon-vitest, stories without a play function are transformed into smoke tests that contain no assertions. This causes the test suite to fail with: Error: expected any number of assertion, but got none.
I modified the
@storybook/addon-vitestplugin to internally override thetest.expect.requireAssertionssetting. This ensures that generated smoke tests pass regardless of the user's global Vitest strictness settings, while keeping the rest of the user's configuration intact via the config hook.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>