From af0cfa7ad006f9d1d333bd869eeff66bc01c507c Mon Sep 17 00:00:00 2001 From: James Garbutt <43081j@users.noreply.github.com> Date: Wed, 5 Nov 2025 12:07:54 +0000 Subject: [PATCH 1/2] chore(renderers/preact): set preact as import source To get rid of the ts-expect-error, we can set the import source as preact so it will resolve preact's `Component` rather than React's. --- code/renderers/preact/src/render.tsx | 2 -- code/renderers/preact/tsconfig.json | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/code/renderers/preact/src/render.tsx b/code/renderers/preact/src/render.tsx index 56c599006e86..9b3d00918204 100644 --- a/code/renderers/preact/src/render.tsx +++ b/code/renderers/preact/src/render.tsx @@ -16,8 +16,6 @@ export const render: ArgsStoryFn = (args, context) => { ); } - // @ts-expect-error I think the type of Component should be Preact.ComponentType, but even that - // doesn't make TS happy, I suspect because TS wants "react" components. return ; }; diff --git a/code/renderers/preact/tsconfig.json b/code/renderers/preact/tsconfig.json index 3b01f80f2c32..7f586cf144de 100644 --- a/code/renderers/preact/tsconfig.json +++ b/code/renderers/preact/tsconfig.json @@ -1,5 +1,7 @@ { "extends": "../../tsconfig.json", - "compilerOptions": {}, + "compilerOptions": { + "jsxImportSource": "preact" + }, "include": ["src/**/*", "template/**/*"] } From 9e8d567320061ae555c77321e9552bf62073a5d8 Mon Sep 17 00:00:00 2001 From: Norbert de Langen Date: Mon, 10 Nov 2025 16:09:31 +0100 Subject: [PATCH 2/2] fix build, avoid using JSX --- code/renderers/preact/src/render.tsx | 2 +- code/renderers/preact/tsconfig.json | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/code/renderers/preact/src/render.tsx b/code/renderers/preact/src/render.tsx index 9b3d00918204..b413306a2f63 100644 --- a/code/renderers/preact/src/render.tsx +++ b/code/renderers/preact/src/render.tsx @@ -16,7 +16,7 @@ export const render: ArgsStoryFn = (args, context) => { ); } - return ; + return h(Component, args); }; let renderedStory: Element; diff --git a/code/renderers/preact/tsconfig.json b/code/renderers/preact/tsconfig.json index 7f586cf144de..3b01f80f2c32 100644 --- a/code/renderers/preact/tsconfig.json +++ b/code/renderers/preact/tsconfig.json @@ -1,7 +1,5 @@ { "extends": "../../tsconfig.json", - "compilerOptions": { - "jsxImportSource": "preact" - }, + "compilerOptions": {}, "include": ["src/**/*", "template/**/*"] }