Skip to content

CoreServer: Fix Arc can't get every window#32508

Merged
ndelangen merged 1 commit into
nextfrom
norbert/remove-arc-special-open-script-support
Sep 22, 2025
Merged

CoreServer: Fix Arc can't get every window#32508
ndelangen merged 1 commit into
nextfrom
norbert/remove-arc-special-open-script-support

Conversation

@ndelangen
Copy link
Copy Markdown
Member

@ndelangen ndelangen commented Sep 19, 2025

What I did

Fix a bug where the applescript tries to get work on Arc, but that does not work.

I removed Arc from the list of browser to try the applescript method.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Adjusted macOS browser integration: Arc is no longer targeted for automatic tab reuse when opening the app. Other Chromium-based browsers remain supported for reusing an existing tab.
    • Users on macOS using Arc may notice the app opens in a different browser or a new window instead of reusing an Arc tab.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 19, 2025

Walkthrough

Removed "Arc" from the Chromium-based browsers list used by the macOS AppleScript path in startBrowserProcess, narrowing the set of browsers checked for tab reuse. No other logic, exports, or control flow changed.

Changes

Cohort / File(s) Summary
Open-browser macOS AppleScript targets
code/core/src/core-server/utils/open-browser/opener.ts
Deleted "Arc" from supportedChromiumBrowsers used by the AppleScript-driven tab reuse loop; no other edits.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

maintenance, ci:normal

Suggested reviewers

  • kasperpeulen
  • yannbf

Poem

I nudge the tabs, hop-light, hop-bright—
One fewer burrow in the Chromium night.
Arc bows out; the script stays keen,
Fewer doors, same tidy scene.
Thump-thump—review’s a nibble, not a bite! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "CoreServer: Fix Arc can't get every window" is concise, focused on a single bug, and directly reflects the primary change in the PR (removing Arc from the macOS AppleScript browser list), so it conveys the main intent clearly to reviewers.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch norbert/remove-arc-special-open-script-support

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 795e05c and 287e6bc.

📒 Files selected for processing (1)
  • code/core/src/core-server/utils/open-browser/opener.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • code/core/src/core-server/utils/open-browser/opener.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Sep 19, 2025

View your CI Pipeline Execution ↗ for commit 287e6bc

Command Status Duration Result
nx run-many -t check -c production --parallel=7 ✅ Succeeded 1m 22s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 3m 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-22 13:20:36 UTC

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: 287e6bc, ran on 22 September 2025 at 13:29:23 UTC

The following packages have significant changes to their size or dependencies:

@storybook/nextjs

Before After Difference
Dependency count 529 529 0
Self size 939 KB 939 KB 🚨 +126 B 🚨
Dependency size 58.64 MB 58.25 MB 🎉 -387 KB 🎉
Bundle Size Analyzer Link Link

@storybook/svelte-vite

Before After Difference
Dependency count 22 19 🎉 -3 🎉
Self size 59 KB 59 KB 0 B
Dependency size 26.89 MB 26.78 MB 🎉 -119 KB 🎉
Bundle Size Analyzer Link Link

@storybook/sveltekit

Before After Difference
Dependency count 23 20 🎉 -3 🎉
Self size 49 KB 49 KB 🚨 +30 B 🚨
Dependency size 26.95 MB 26.84 MB 🎉 -119 KB 🎉
Bundle Size Analyzer Link Link

@ndelangen ndelangen merged commit 8fdeb1a into next Sep 22, 2025
63 of 66 checks passed
@ndelangen ndelangen deleted the norbert/remove-arc-special-open-script-support branch September 22, 2025 14:12
@github-actions github-actions Bot mentioned this pull request Sep 22, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants