CI: Update CircleCI config to support "Rerun failed tests" feature#31993
Merged
Conversation
ghengeveld
added
build
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| yarn test --reporter=blob --reporter=default $TEST_PATTERNS | ||
| else | ||
| echo "No test files found for this shard" | ||
| exit 0 |
Contributor
There was a problem hiding this comment.
style: Exit code 0 for no tests could mask CI issues. Consider non-zero exit for unexpected empty shards
|
View your CI Pipeline Execution ↗ for commit 5a86dce
☁️ Nx Cloud last updated this comment at |
- Ensure .vitest-reports directory exists before test execution - Create empty test report when no files assigned to shard - Add robust error handling in store-test-results for missing reports - Prevent workspace persistence failures on first run with no timing data Fixes "No test files found for this shard" and workspace persistence errors that occurred when CircleCI test splitting had no historical timing data to work with.
- Add output logging for circleci tests glob command before splitting - Show glob results to understand why test files aren't being found - Compare find vs circleci tests glob output for troubleshooting Helps diagnose why "No test files found for this shard" occurs despite test files being visible to the find command.
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
ghengeveld
commented
Jul 9, 2025
ndelangen
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31292
What I did
Updated the CircleCI config to enable the "Rerun failed tests" feature. This allows us to rerun only the unit tests that failed (example).
I've also simplified the setup by removing the separate
store-test-resultsstep. With the new setup it doesn't seem to be necessary to manually merge test results into a single junit.xml anymore. CircleCI accepts a separate junit.xml file from each parallel run, and reports the (correct) total number of tests. An extra benefit is that the test results are now reported on the unit-test task itself (e.g. here) rather than a separate later task (e.g. here).Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates CircleCI configuration to support the 'Rerun failed tests' feature, improving test execution efficiency and reliability.
.circleci/scripts/run-tests.shfor intelligent test sharding and execution using Vitestconfig.ymlto dedicated shell script for better organization.editorconfigto enforce single quotes in YAML files