CSF: Add Storybook test syntax#31551
Conversation
|
View your CI Pipeline Execution ↗ for commit 319ace2
☁️ Nx Cloud last updated this comment at |
30ea99d to
81e9c77
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 18 | 12 | 🎉 -6 🎉 |
| Self size | 2.01 MB | 2.47 MB | 🚨 +460 KB 🚨 |
| Dependency size | 9.40 MB | 8.93 MB | 🎉 -471 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-jest
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 2 | 0 |
| Self size | 47 KB | 38 KB | 🎉 -9 KB 🎉 |
| Dependency size | 53 KB | 53 KB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-links
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 1 | 1 | 0 |
| Self size | 15 KB | 20 KB | 🚨 +5 KB 🚨 |
| Dependency size | 5 KB | 5 KB | 🚨 +5 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-onboarding
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 0 | 0 | 0 |
| Self size | 332 KB | 228 KB | 🎉 -105 KB 🎉 |
| Dependency size | 667 B | 667 B | 0 B |
| Bundle Size Analyzer | Link | Link |
storybook-addon-pseudo-states
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 0 | 0 | 0 |
| Self size | 23 KB | 47 KB | 🚨 +24 KB 🚨 |
| Dependency size | 686 B | 686 B | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-vitest
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 6 | 6 | 0 |
| Self size | 495 KB | 553 KB | 🚨 +58 KB 🚨 |
| Dependency size | 1.49 MB | 1.49 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/builder-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 11 | 5 | 🎉 -6 🎉 |
| Self size | 374 KB | 449 KB | 🚨 +75 KB 🚨 |
| Dependency size | 1.30 MB | 834 KB | 🎉 -469 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/builder-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 186 | 198 | 🚨 +12 🚨 |
| Self size | 68 KB | 80 KB | 🚨 +13 KB 🚨 |
| Dependency size | 31.37 MB | 31.45 MB | 🚨 +78 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 48 | 50 | 🚨 +2 🚨 |
| Self size | 30.74 MB | 41.77 MB | 🚨 +11.03 MB 🚨 |
| Dependency size | 17.61 MB | 16.59 MB | 🎉 -1.02 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/angular
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 186 | 199 | 🚨 +13 🚨 |
| Self size | 134 KB | 191 KB | 🚨 +57 KB 🚨 |
| Dependency size | 29.60 MB | 29.78 MB | 🚨 +182 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 191 | 203 | 🚨 +12 🚨 |
| Self size | 17 KB | 28 KB | 🚨 +11 KB 🚨 |
| Dependency size | 28.09 MB | 28.18 MB | 🚨 +91 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/html-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 14 | 8 | 🎉 -6 🎉 |
| Self size | 23 KB | 23 KB | 🚨 +75 B 🚨 |
| Dependency size | 1.71 MB | 1.33 MB | 🎉 -386 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 529 | 538 | 🚨 +9 🚨 |
| Self size | 928 KB | 903 KB | 🎉 -25 KB 🎉 |
| Dependency size | 58.28 MB | 59.35 MB | 🚨 +1.07 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/nextjs-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 131 | 130 | 🎉 -1 🎉 |
| Self size | 4.00 MB | 3.08 MB | 🎉 -927 KB 🎉 |
| Dependency size | 21.44 MB | 22.30 MB | 🚨 +859 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 14 | 8 | 🎉 -6 🎉 |
| Self size | 14 KB | 13 KB | 🎉 -1 KB 🎉 |
| Dependency size | 1.70 MB | 1.31 MB | 🎉 -389 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 164 | 163 | 🎉 -1 🎉 |
| Self size | 31 KB | 32 KB | 🚨 +574 B 🚨 |
| Dependency size | 22.83 MB | 23.69 MB | 🚨 +859 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 121 | 120 | 🎉 -1 🎉 |
| Self size | 36 KB | 32 KB | 🎉 -4 KB 🎉 |
| Dependency size | 19.39 MB | 20.25 MB | 🚨 +863 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 272 | 286 | 🚨 +14 🚨 |
| Self size | 25 KB | 25 KB | 🎉 -179 B 🎉 |
| Dependency size | 43.02 MB | 43.77 MB | 🚨 +749 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/server-webpack5
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 198 | 210 | 🚨 +12 🚨 |
| Self size | 17 KB | 17 KB | 🎉 -180 B 🎉 |
| Dependency size | 32.62 MB | 32.72 MB | 🚨 +96 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/svelte-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 22 | 17 | 🎉 -5 🎉 |
| Self size | 59 KB | 53 KB | 🎉 -6 KB 🎉 |
| Dependency size | 26.95 MB | 26.66 MB | 🎉 -292 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/sveltekit
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 23 | 18 | 🎉 -5 🎉 |
| Self size | 49 KB | 51 KB | 🚨 +2 KB 🚨 |
| Dependency size | 27.01 MB | 26.71 MB | 🎉 -297 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 110 | 105 | 🎉 -5 🎉 |
| Self size | 38 KB | 34 KB | 🎉 -4 KB 🎉 |
| Dependency size | 43.82 MB | 43.53 MB | 🎉 -285 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/web-components-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 15 | 9 | 🎉 -6 🎉 |
| Self size | 20 KB | 20 KB | 🚨 +49 B 🚨 |
| Dependency size | 1.74 MB | 1.36 MB | 🎉 -381 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 0 | 51 | 🚨 +51 🚨 |
| Self size | 0 B | 1 KB | 🚨 +1 KB 🚨 |
| Dependency size | 0 B | 58.36 MB | 🚨 +58.36 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 204 | 219 | 🚨 +15 🚨 |
| Self size | 879 KB | 585 KB | 🎉 -294 KB 🎉 |
| Dependency size | 81.70 MB | 102.88 MB | 🚨 +21.18 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 173 | 188 | 🚨 +15 🚨 |
| Self size | 35 KB | 31 KB | 🎉 -4 KB 🎉 |
| Dependency size | 76.77 MB | 86.96 MB | 🚨 +10.19 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/core-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 1 | 1 | 0 |
| Self size | 12 KB | 16 KB | 🚨 +4 KB 🚨 |
| Dependency size | 28 KB | 28 KB | 0 B |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 1 | 🎉 -48 🎉 |
| Self size | 1.52 MB | 12.52 MB | 🚨 +11.00 MB 🚨 |
| Dependency size | 48.35 MB | 98 KB | 🎉 -48.25 MB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/csf-plugin
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 9 | 3 | 🎉 -6 🎉 |
| Self size | 9 KB | 11 KB | 🚨 +2 KB 🚨 |
| Dependency size | 1.27 MB | 796 KB | 🎉 -471 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
eslint-plugin-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 35 | 35 | 0 |
| Self size | 139 KB | 321 KB | 🚨 +182 KB 🚨 |
| Dependency size | 3.41 MB | 3.41 MB | 🚨 +55 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-dom-shim
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 0 | 0 | 0 |
| Self size | 12 KB | 10 KB | 🎉 -2 KB 🎉 |
| Dependency size | 785 B | 795 B | 🚨 +10 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-create-react-app
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 68 | 68 | 0 |
| Self size | 26 KB | 18 KB | 🎉 -8 KB 🎉 |
| Dependency size | 5.97 MB | 5.97 MB | 🚨 +1 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-react-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 170 | 177 | 🚨 +7 🚨 |
| Self size | 26 KB | 24 KB | 🎉 -2 KB 🎉 |
| Dependency size | 30.55 MB | 30.61 MB | 🚨 +62 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-server-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 10 | 10 | 0 |
| Self size | 8 KB | 10 KB | 🚨 +2 KB 🚨 |
| Dependency size | 1.20 MB | 1.20 MB | 🚨 +4 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/html
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 2 | 0 |
| Self size | 30 KB | 38 KB | 🚨 +8 KB 🚨 |
| Dependency size | 32 KB | 32 KB | 🚨 +55 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 2 | 0 |
| Self size | 17 KB | 23 KB | 🚨 +6 KB 🚨 |
| Dependency size | 32 KB | 32 KB | 🚨 +55 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 2 | 0 |
| Self size | 872 KB | 1.66 MB | 🚨 +789 KB 🚨 |
| Dependency size | 18 KB | 16 KB | 🎉 -2 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/server
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 3 | 3 | 0 |
| Self size | 9 KB | 13 KB | 🚨 +4 KB 🚨 |
| Dependency size | 716 KB | 716 KB | 🚨 +55 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/svelte
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 2 | 0 |
| Self size | 48 KB | 64 KB | 🚨 +16 KB 🚨 |
| Dependency size | 230 KB | 230 KB | 🚨 +55 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 3 | 3 | 0 |
| Self size | 61 KB | 83 KB | 🚨 +22 KB 🚨 |
| Dependency size | 211 KB | 211 KB | 🚨 +55 B 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/web-components
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 3 | 3 | 0 |
| Self size | 43 KB | 57 KB | 🚨 +13 KB 🚨 |
| Dependency size | 47 KB | 47 KB | 🚨 +55 B 🚨 |
| Bundle Size Analyzer | Link | Link |
|
Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/16520141752 |
b9a4ccd to
1086746
Compare
|
Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/16520565169 |
|
Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/16723091606 |
- Updated HighlightStyles to include 'test' nodetype for styling. - Added 'subtype' property to mock dataset entries for better differentiation between story and test types. - Modified Tree and TreeNode components to handle test entries correctly. - Adjusted API types to separate story and test entries for clearer structure. - Improved event handling in useExpanded and useHighlighted hooks to include tests.
…nent - Introduced 'play-fn' and 'test-fn' tags with default selection in common-preset. - Enhanced Sidebar component to utilize tag presets for managing selected tags. - Updated TagsFilter to initialize selected tags based on tag presets. - Modified TagsFilter stories to reflect new tag preset functionality.
Core: Add default selection for tags in main config
|
Failed to publish canary version of this pull request, triggered by @yannbf. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/17409216087 |
…ultSelection for tags
…retrieving story tests
…act, and track the parent story name for a test. - Updated 'story' property to always be the story name rather than the test name - Added 'storyId' property to point to the parent story from a test
CSF: Refactor CsfFile to support tests and tags
Core: Update `StoryStore.extract` to handle tests
|
Closing this in favor of #32391 |
Closes #32244
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31551-sha-cd66148d. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-31551-sha-cd66148d sandboxor in an existing project withnpx storybook@0.0.0-pr-31551-sha-cd66148d upgrade.More information
0.0.0-pr-31551-sha-cd66148dyann/test-fn-prototypecd66148d1756889619)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31551