Tags: Add story/meta usage telemetry#30555
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 77dc3c3.
☁️ Nx Cloud last updated this comment at |
9 tasks
Merged
9 tasks
shilman
added a commit
that referenced
this pull request
Feb 18, 2025
Tags: Add story/meta usage telemetry (cherry picked from commit e8009f3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Count the number of stories/meta that use tags. Does not include the implicit
dev/testtags or tags that are added inpreview.js.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Added telemetry tracking for tags usage in Storybook stories by implementing tag counting across story and meta annotations.
tagsboolean property toIndexInputStatsinterface incode/core/src/types/modules/indexer.tstagsto tracked annotations incode/core/src/csf-tools/CsfFile.tsfor story statsStoryIndexGenerator.test.tsfor tags counting across different scenariosCsfFile.test.tsfor tag handling in CSF2/CSF3 formatsThe changes are minimal and focused on adding telemetry capabilities without modifying existing functionality. The implementation appears thorough with good test coverage for various tag usage scenarios.