Skip to content

CLI: Fix doctor compatibility check#26363

Merged
ndelangen merged 2 commits into
nextfrom
fix/doctor-compat-check
Mar 7, 2024
Merged

CLI: Fix doctor compatibility check#26363
ndelangen merged 2 commits into
nextfrom
fix/doctor-compat-check

Conversation

@yannbf

@yannbf yannbf commented Mar 7, 2024

Copy link
Copy Markdown
Member

What I did

The logic to detect version incompatibility did not support version ranges e.g. ^7.0.0 || ^8.0.0, now it does.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf self-assigned this Mar 7, 2024
@yannbf yannbf added bug cli ci:normal Run our default set of CI jobs (choose this for most PRs). labels Mar 7, 2024
@yannbf yannbf requested a review from ndelangen March 7, 2024 10:32
@nx-cloud

nx-cloud Bot commented Mar 7, 2024

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 83303b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@vanessayuenn vanessayuenn added this to the 8.0-Stable milestone Mar 7, 2024
@ndelangen ndelangen merged commit 247015e into next Mar 7, 2024
@ndelangen ndelangen deleted the fix/doctor-compat-check branch March 7, 2024 18:03
@github-actions github-actions Bot mentioned this pull request Mar 7, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). cli

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants