CLI: Remove random commas in storybook upgrade logs#22333
Merged
Conversation
Prevents commas from being logged on the terminal Adds newline between stdout and stderr
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22298
What I did
Log the
stdoutandstderrproperties, instead of loggingoutputproperty of result returned bynpm-check-updates@latest.This provides the following benefits:
stdoutandstderrare equal tooutput[1]andoutput[2]respectively.stderrcan be logged at a different level tostdout(not sure what the rule for using info or warn on logs)It also:
output[0]which in this case is null.stdoutandstderrlogsAn example of what the logs look like before and after with some forced warnings (using reproduction code):
How to test
yarn task --task sandbox --start-from auto --template react-vite/default-tsnpx storybook@latest upgradenpm-check-updatesChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]