Skip to content

Viewport: Fix the defaultOrientation config option#21536

Closed
jpzwarte wants to merge 1 commit into
storybookjs:nextfrom
jpzwarte:fix/viewport-orientation
Closed

Viewport: Fix the defaultOrientation config option#21536
jpzwarte wants to merge 1 commit into
storybookjs:nextfrom
jpzwarte:fix/viewport-orientation

Conversation

@jpzwarte

Copy link
Copy Markdown
Contributor

So #21048 was actually broken. This fixes that (tested this time!).

@shilman shilman changed the title Fix the defaultOrientation config option of the viewport addon. Viewport: Fix the defaultOrientation config option Mar 13, 2023
@ndelangen

Copy link
Copy Markdown
Member

@shilman I think this is actually a good bugfix to merge into 7.0. WDYT?

@jpzwarte jpzwarte closed this by deleting the head repository Mar 14, 2023
@ndelangen

Copy link
Copy Markdown
Member

@jpzwarte did you intend to delete the branch (which auto-closes PRs)?

@jpzwarte

Copy link
Copy Markdown
Contributor Author

NO :(

@jpzwarte jpzwarte reopened this Mar 15, 2023
@jpzwarte

Copy link
Copy Markdown
Contributor Author

I removed my local fork, which caused this PR to be closed :( Was not my intention.

@valentinpalkovic

Copy link
Copy Markdown
Contributor

@ndelangen Can we merge this one?

@ndelangen

Copy link
Copy Markdown
Member

I can't update this @jpzwarte

(next) % git remote add jpzwarte git@github.com:jpzwarte/storybook.git                                                                                                                                                                                                 ~/Projects/Storybook/core
git fetch jpzwarte fix/viewport-orientation
git switch --track jpzwarte/fix/viewport-orientation
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: invalid reference: jpzwarte/fix/viewport-orientation

@jpzwarte

jpzwarte commented Apr 6, 2023

Copy link
Copy Markdown
Contributor Author

@ndelangen see the new PR: #21962

@jpzwarte jpzwarte closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants