Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorators may get applied multiple times #854

Closed
shilman opened this issue Apr 15, 2017 · 2 comments
Closed

Decorators may get applied multiple times #854

shilman opened this issue Apr 15, 2017 · 2 comments
Labels

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by mnmtanish
Tuesday Jul 26, 2016 at 07:27 GMT
Originally opened as storybook-eol/react-native-storybook#50


Check whether this issue reported on react-storybook repo exists here. It is more likely that it does. Unfortunately we can't apply the solution used there because react-native HMR does not support dispose handlers. Investigate this issue and find a good solution.

If the issue exists, I think users can prevent it by manually calling clearDecorators from the config.js file. Global decorators are not that common so this issue is not critical. We can do it after optimising ios/android setup guides.

@shilman shilman added the bug label Apr 15, 2017
@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by mnmtanish
Tuesday Nov 08, 2016 at 11:06 GMT


TODO:

  • try to reproduce this issue and check whether it exists
  • find a solution without adding extra config for users

@shilman shilman closed this as completed Apr 15, 2017
@macrozone
Copy link
Contributor

@shilman why is this closed? This is still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants