Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can only use one device at a time #831

Closed
shilman opened this issue Apr 15, 2017 · 11 comments
Closed

Can only use one device at a time #831

shilman opened this issue Apr 15, 2017 · 11 comments

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by mnmtanish
Tuesday Jun 21, 2016 at 06:35 GMT
Originally opened as storybook-eol/react-native-storybook#6


Only one device can use the packager server at a time. It would be great if the storybook can be run on multiple devices simultaneously.

screen shot 2016-06-21 at 12 03 42 pm 2
screen shot 2016-06-21 at 12 03 56 pm 2

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by mnmtanish
Sunday Jul 17, 2016 at 18:15 GMT


This can be done using the bundled version. Unfortunately it won't work with hot module reloading.

@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by mnmtanish
Sunday Jul 17, 2016 at 18:31 GMT


Created a feature request on productpains.com here.

@ndelangen
Copy link
Member

@Gongreg @tmeasday Is this still true? I heard someone say he could connect multiple devices?

Can you close or comment?

@tmeasday
Copy link
Member

I'm really not sure.

@shilman
Copy link
Member Author

shilman commented Jul 17, 2017

I don't know the solution but @ajwhite figured this out. It hasn't been merged/contributed yet.

@danhawkes
Copy link

@shilman Can you point to where @ajwhite says this? Can't find it in any of the related issues.

@Gongreg
Copy link
Member

Gongreg commented Aug 17, 2017

There are two solutions:

  1. Running hosted storybook server, so multiple devices can connect on same storybook server (work in progress to make it easier to use).

  2. Start multiple storybooks with different ports (if not implemented shouldn't be difficult to implement).

@danhawkes
Copy link

The use-case I'd like to see supported would be to control multiple devices simulataneously via the storybook UI. E.g. I click on a story and all devices update to show that story. Ideally the UI could show a list of connected devices somewhere.

Think the only way that can work is via solution 1. Not clear on why it'd need to be hosted though? - assuming the storybook UI is already acting as a server and the device as a client.

@Gongreg
Copy link
Member

Gongreg commented Aug 17, 2017

Right, you can actually do that but only for multiple devices of same type (either ios or android). If you try to mix and match it starts to fail. But for multiple ios devices it works as you expect, you click on story and all devices show the story.

But you could try to start storybook separately (npm run storybook --skip-packager) from packager and then start as many packagers as you want.

@stale stale bot added the inactive label Nov 2, 2017
@stale stale bot removed the inactive label Nov 2, 2017
@storybookjs storybookjs deleted a comment from stale bot Nov 2, 2017
@stale
Copy link

stale bot commented Dec 18, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Dec 18, 2017
@Gongreg
Copy link
Member

Gongreg commented Dec 18, 2017

I think we can close this issue. If you have questions you can ask more about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants