Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL queries for controlling contexts in the SB full iFrame mode #6602

Closed
leoyli opened this issue Apr 24, 2019 · 3 comments
Closed

Add URL queries for controlling contexts in the SB full iFrame mode #6602

leoyli opened this issue Apr 24, 2019 · 3 comments

Comments

@leoyli
Copy link
Contributor

leoyli commented Apr 24, 2019

Is your feature request related to a problem? Please describe.
For snapshot testing and story sharing purposes, it would be nice to have the URL query parameters to determine which contextual environment should be applied in the SB full iFrame mode.

Describe the solution you'd like
The same approach done in addon-contexts.

Describe alternatives you've considered
N/A

Are you able to assist bring the feature to reality?
Yes, done.

Additional context
N/A

@leoyli leoyli added this to the 5.1.0 milestone Apr 24, 2019
@leoyli leoyli self-assigned this Apr 24, 2019
@leoyli
Copy link
Contributor Author

leoyli commented Apr 24, 2019

Related to #6601.

@leoyli leoyli changed the title Add URL queries for controlling contexts in the SB full iFrame mode #15 Add URL queries for controlling contexts in the SB full iFrame mode Apr 24, 2019
@leoyli leoyli closed this as completed Apr 24, 2019
@shilman
Copy link
Member

shilman commented Apr 24, 2019

Deployed in https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.34

@leoyli if the PR had referenced this issue on the first line, this comment would have been generated and issue would have been closed automagically 😉 I updated the comment just now, but it needs to be correct before I run the publish script

@leoyli
Copy link
Contributor Author

leoyli commented Apr 24, 2019

Oh I see, sorry about that 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants