Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL - in v5 old url structure is not working #6402

Closed
mortal94 opened this issue Apr 3, 2019 · 1 comment
Closed

URL - in v5 old url structure is not working #6402

mortal94 opened this issue Apr 3, 2019 · 1 comment
Milestone

Comments

@mortal94
Copy link
Contributor

mortal94 commented Apr 3, 2019

Describe the bug
When using the old URL structure of storybook v4 in storybook v5 it'll select the story in the sidebar (stories tree) and also will change the url to the new structure of v5, but the story view will not show the selected story and will show an error of "No preview".

To Reproduce
Steps to reproduce the behavior:

  1. Go to the link below (offical storybook site with old structured URL)
    https://storybooks-official.netlify.com/?selectedKind=addons-knobs-withknobs&selectedStory=tweaks-static-values
  2. See that the story is selected and also the URL have changed to the new URL structure but the story view shows "No preview" error.
  3. Refresh the page and it'll load the page with the new url (because it was replaced) and the story view will load.

Expected behavior
For now as the documentation and code reference that the old URL structure is still being supported, so the expected behavior is that the story view will also load the selected story according to the old structure URL.

Screenshots
Screen Shot 2019-04-03 at 17 09 49

System:

  • OS: MacOS
  • Device: Macbook Pro 2018
  • Browser: chrome
  • Framework: react - but any framework?
  • Version: 5.0.x and 5.1.x
@mortal94 mortal94 changed the title Url - in v5 old url structure is not working URL - in v5 old url structure is not working Apr 3, 2019
@shilman
Copy link
Member

shilman commented Apr 9, 2019

Sorry for the delay @mortal94 somehow this didn't show up in my notifications.

Closing as a dupe to #6075

@shilman shilman closed this as completed Apr 9, 2019
@shilman shilman added this to the 5.0.x milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants