-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.3>6.0 Migration Vue: controls dont update stories in both docs and canvas tabs #11990
Comments
FYI, we’ve released Please upgrade and try them out today! |
Thanks, I did try to migrate to controls but it seemed the documentation for the Vue implementation was not complete so I wasnt sure how to migrate |
I was able to produce the same issue with the new controls syntax, I also simplified the case. You can see in the demo, only the name is reactive AppIcon.vue
AppIcon.stories.js
|
Reproduced on version 6.0.7 |
There’s a known bug where controls only update on inline stories on Docs tab. #11908 |
Do you have a repro repo? Screenshots are not enough to identify what the problem is |
I made a repro, it is failing to show tabs, maybe the zero config essential addons are broken too? |
Reproduction is now showing the controls and showing the issue |
What issue does it show? When I clone the repo & run it, controls seem to work for me. |
Describe the bug
Knobs no longer reactively update the props on all components, removing the component from the export default seems to make the component reactive again. At the cost of loosing the docs
To Reproduce
AppIcon.vue
AppIcon.stories.js
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Code snippets
If applicable, add code samples to help explain your problem.
System:
Additional context
Making this change makes the props work as before
The text was updated successfully, but these errors were encountered: