-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement polished's cssVar to add CSS variable support fully to theming. #10170
Comments
Can you explain the use case a bit more? Sounds like a great improvement but I don't quite get it yet. @ndelangen should be able to help if you have any q's about contributing! |
@bhough that's great news! We'd love to take a PR fixing this. What do you think about using that util function in the |
@ndelangen Great, |
Hi, Is this issue fixed? I have a library of ui-components, all written in Stencil.JS, using css-variables. Regards. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
Is your feature request related to a problem? Please describe.
Previously theming would break when passed a CSS variable due to
polished
not supporting pulling variable values (#6135). A workaround was put in place (#6939) to guard against this but didn't add the ability to leverage them.Describe the solution you'd like
We now provide a helper in
polished
that fetches CSS Variable values (https://polished.js.org/docs/#cssvar) and we'd like to help implement it into theming to provide support for CSS variables.Describe alternatives you've considered
N/A
Are you able to assist bring the feature to reality?
Yes!
The text was updated successfully, but these errors were encountered: