Skip to content

Commit 4bbfb14

Browse files
authored
Merge pull request #28943 from storybookjs/kasper/viewport
Vitest: Fix default viewport
2 parents accf304 + 88a0059 commit 4bbfb14

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

code/addons/vitest/src/plugin/viewports.test.ts

+3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
/* eslint-disable no-underscore-dangle */
22
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
33

4+
import { INITIAL_VIEWPORTS } from '@storybook/addon-viewport';
5+
46
import { page } from '@vitest/browser/context';
57

68
import { DEFAULT_VIEWPORT_DIMENSIONS, type ViewportsParam, setViewport } from './viewports';
@@ -42,6 +44,7 @@ describe('setViewport', () => {
4244

4345
it('should set the dimensions of viewport from INITIAL_VIEWPORTS', async () => {
4446
const viewportsParam: any = {
47+
viewports: INITIAL_VIEWPORTS,
4548
// supported by default in addon viewports
4649
defaultViewport: 'ipad',
4750
};

code/addons/vitest/src/plugin/viewports.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { UnsupportedViewportDimensionError } from 'storybook/internal/preview-er
33

44
import { page } from '@vitest/browser/context';
55

6-
import { INITIAL_VIEWPORTS } from '../../../viewport/src/defaults';
6+
import { MINIMAL_VIEWPORTS } from '../../../viewport/src/defaults';
77
import type { ViewportMap, ViewportStyles } from '../../../viewport/src/types';
88

99
declare global {
@@ -50,12 +50,12 @@ const parseDimension = (value: string, dimension: 'width' | 'height') => {
5050
export const setViewport = async (viewportsParam: ViewportsParam = {} as ViewportsParam) => {
5151
const defaultViewport = viewportsParam.defaultViewport;
5252

53-
if (!page || !globalThis.__vitest_browser__ || !defaultViewport) {
53+
if (!page || !globalThis.__vitest_browser__) {
5454
return;
5555
}
5656

5757
const viewports = {
58-
...INITIAL_VIEWPORTS,
58+
...MINIMAL_VIEWPORTS,
5959
...viewportsParam.viewports,
6060
};
6161

0 commit comments

Comments
 (0)