Skip to content

Commit 20c0b10

Browse files
Merge remote-tracking branch 'origin/next' into valentin/fix-skip-install-installation
2 parents 4ebba9a + 7262c52 commit 20c0b10

File tree

6 files changed

+22
-18
lines changed

6 files changed

+22
-18
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## 8.3.1
2+
3+
- Angular: Fix sourceDecorator to apply excludeDecorators flag - [#29069](https://github.com/storybookjs/storybook/pull/29069), thanks @JSMike!
4+
- Core: Do not prebundle better-opn - [#29137](https://github.com/storybookjs/storybook/pull/29137), thanks @valentinpalkovic!
5+
- Core: Do not prebundle jsdoc-type-pratt-parser - [#29134](https://github.com/storybookjs/storybook/pull/29134), thanks @valentinpalkovic!
6+
- Next.js: Upgrade sass-loader from ^12 to ^13 - [#29040](https://github.com/storybookjs/storybook/pull/29040), thanks @HoncharenkoZhenya!
7+
18
## 8.3.0
29

310
Fresh out of the oven! Storybook 8.3 brings you:

code/core/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -279,10 +279,12 @@
279279
"dependencies": {
280280
"@storybook/csf": "^0.1.11",
281281
"@types/express": "^4.17.21",
282+
"better-opn": "^3.0.2",
282283
"browser-assert": "^1.2.1",
283284
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0",
284285
"esbuild-register": "^3.5.0",
285286
"express": "^4.19.2",
287+
"jsdoc-type-pratt-parser": "^4.0.0",
286288
"process": "^0.11.10",
287289
"recast": "^0.23.5",
288290
"semver": "^7.6.2",
@@ -340,7 +342,6 @@
340342
"ansi-to-html": "^0.7.2",
341343
"assert": "^2.1.0",
342344
"babel-plugin-react-docgen": "4.2.1",
343-
"better-opn": "^3.0.2",
344345
"boxen": "^7.1.1",
345346
"browser-dtector": "^3.4.0",
346347
"camelcase": "^8.0.0",
@@ -378,7 +379,6 @@
378379
"globby": "^14.0.1",
379380
"handlebars": "^4.7.7",
380381
"js-yaml": "^4.1.0",
381-
"jsdoc-type-pratt-parser": "^4.0.0",
382382
"lazy-universal-dotenv": "^4.0.0",
383383
"leven": "^4.0.0",
384384
"lodash": "^4.17.21",

code/e2e-tests/addon-docs.spec.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -196,11 +196,7 @@ test.describe('addon-docs', () => {
196196

197197
// Arrange - Setup expectations
198198
let expectedReactVersionRange = /^18/;
199-
if (
200-
templateName.includes('preact') ||
201-
templateName.includes('react-webpack/17') ||
202-
templateName.includes('react-vite/17')
203-
) {
199+
if (templateName.includes('react-webpack/17') || templateName.includes('react-vite/17')) {
204200
expectedReactVersionRange = /^17/;
205201
} else if (templateName.includes('react16')) {
206202
expectedReactVersionRange = /^16/;

code/frameworks/angular/src/client/docs/sourceDecorator.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { SNIPPET_RENDERED, SourceType } from 'storybook/internal/docs-tools';
22
import { addons, useEffect } from 'storybook/internal/preview-api';
3-
import { PartialStoryFn } from 'storybook/internal/types';
3+
import { ArgsStoryFn, PartialStoryFn } from 'storybook/internal/types';
44

55
import { computesTemplateSourceFromComponent } from '../../renderer';
66
import { AngularRenderer, StoryContext } from '../types';
@@ -32,9 +32,11 @@ export const sourceDecorator = (
3232
return story;
3333
}
3434
const channel = addons.getChannel();
35-
const { props, template, userDefinedTemplate } = story;
36-
35+
const { props, userDefinedTemplate } = story;
3736
const { component, argTypes, parameters } = context;
37+
const template: string = parameters.docs?.source?.excludeDecorators
38+
? (context.originalStoryFn as ArgsStoryFn<AngularRenderer>)(context.args, context).template
39+
: story.template;
3840

3941
let toEmit: string;
4042

code/frameworks/nextjs/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157
"postcss-loader": "^8.1.1",
158158
"react-refresh": "^0.14.0",
159159
"resolve-url-loader": "^5.0.0",
160-
"sass-loader": "^12.4.0",
160+
"sass-loader": "^13.2.0",
161161
"semver": "^7.3.5",
162162
"style-loader": "^3.3.1",
163163
"styled-jsx": "^5.1.6",

code/yarn.lock

+6-7
Original file line numberDiff line numberDiff line change
@@ -6445,7 +6445,7 @@ __metadata:
64456445
postcss-loader: "npm:^8.1.1"
64466446
react-refresh: "npm:^0.14.0"
64476447
resolve-url-loader: "npm:^5.0.0"
6448-
sass-loader: "npm:^12.4.0"
6448+
sass-loader: "npm:^13.2.0"
64496449
semver: "npm:^7.3.5"
64506450
sharp: "npm:^0.33.3"
64516451
style-loader: "npm:^3.3.1"
@@ -25305,15 +25305,14 @@ __metadata:
2530525305
languageName: node
2530625306
linkType: hard
2530725307

25308-
"sass-loader@npm:^12.4.0":
25309-
version: 12.6.0
25310-
resolution: "sass-loader@npm:12.6.0"
25308+
"sass-loader@npm:^13.2.0":
25309+
version: 13.3.3
25310+
resolution: "sass-loader@npm:13.3.3"
2531125311
dependencies:
25312-
klona: "npm:^2.0.4"
2531325312
neo-async: "npm:^2.6.2"
2531425313
peerDependencies:
2531525314
fibers: ">= 3.1.0"
25316-
node-sass: ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0
25315+
node-sass: ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0
2531725316
sass: ^1.3.0
2531825317
sass-embedded: "*"
2531925318
webpack: ^5.0.0
@@ -25326,7 +25325,7 @@ __metadata:
2532625325
optional: true
2532725326
sass-embedded:
2532825327
optional: true
25329-
checksum: 10c0/e1ef655f3898cc4c45f02b3c627f8baf998139993a9a79c524153a80814282bfe20d8d8d703b8cf1d05457c1930940b65e2156d11285ed0861f9a1016f993e53
25328+
checksum: 10c0/5e955a4ffce35ee0a46fce677ce51eaa69587fb5371978588c83af00f49e7edc36dcf3bb559cbae27681c5e24a71284463ebe03a1fb65e6ecafa1db0620e3fc8
2533025329
languageName: node
2533125330
linkType: hard
2533225331

0 commit comments

Comments
 (0)