Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll doesn't scroll to end when bottom tab is opened #669

Open
Cancercookie opened this issue Jan 21, 2025 · 11 comments
Open

Scroll doesn't scroll to end when bottom tab is opened #669

Cancercookie opened this issue Jan 21, 2025 · 11 comments

Comments

@Cancercookie
Copy link

Describe the bug

When I open the control section of a component with a lot of props I cannot scroll to the bottom of the list unless I open the bottom sheet more.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a component with a lot of props
  2. Open the control section
  3. Scroll to the bottom of the list
  4. See issue
  5. Open the sheet more
  6. issue stops

Expected behavior
I should always be able to scroll the full list even with the bottom sheet partially hidden

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-21.at.11.43.09.mp4
@dannyhw
Copy link
Member

dannyhw commented Jan 21, 2025

Can you share the version you are using? not seeing the same here

Screen.Recording.2025-01-21.at.13.21.19.mov

@dannyhw
Copy link
Member

dannyhw commented Jan 21, 2025

hmm ok I can see some kind of issue on android

@Cancercookie
Copy link
Author

I have this on iOS with all storybook dependencies at 8.5.0. At this point I think there's something wrong on my side, strange because I have that behaviour only on controls (not in the components list)

@dannyhw
Copy link
Member

dannyhw commented Jan 21, 2025

@Cancercookie what version of gorhoms bottomsheet are you using?

@Cancercookie
Copy link
Author

"@gorhom/bottom-sheet": "^5.0.6",

@dannyhw
Copy link
Member

dannyhw commented Jan 21, 2025

@Cancercookie can you try this version and see if its any better? 8.5.2-alpha.0

@Cancercookie
Copy link
Author

sadly nope

@dannyhw
Copy link
Member

dannyhw commented Jan 21, 2025

@Cancercookie what emulator are you using?

@Cancercookie
Copy link
Author

iOS 17.5 (iPhone 15 Pro), macOS default simulator

@dannyhw
Copy link
Member

dannyhw commented Jan 21, 2025

ok after work I will do a bit more testing, thanks for the information 🙏

@dannyhw
Copy link
Member

dannyhw commented Jan 23, 2025

@Cancercookie I haven't been able to reproduce this, I'm wondering if you could provide a reproduction

also maybe you have extra safe area in your code at the bottom which might be interfering with the height calculation, if you do try removing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants