From bfca2af6213420185bfb1157be665a78b38fb45b Mon Sep 17 00:00:00 2001 From: Julien Huang Date: Fri, 19 Jun 2026 16:27:20 +0200 Subject: [PATCH 1/5] fix(ade): skip stories skill if no explicit skill invocation --- packages/claude-plugin/skills/stories/SKILL.md | 3 +-- .../codex-plugin/plugins/storybook/skills/stories/SKILL.md | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/claude-plugin/skills/stories/SKILL.md b/packages/claude-plugin/skills/stories/SKILL.md index 3ef13c85..051b4e2f 100644 --- a/packages/claude-plugin/skills/stories/SKILL.md +++ b/packages/claude-plugin/skills/stories/SKILL.md @@ -34,8 +34,7 @@ stories in sync with every frontend component you create, modify, or delete. ## Prerequisites -- Storybook must be installed in the project. If it is not, go to - "When Storybook is not installed" below and stop here unless the user opts in. +- Storybook must be installed in the project. If it is not installed and if this skill is not explicitly invoked by the user, silently ignore this skill. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **storybook-upgrade** skill to upgrade it before proceeding. diff --git a/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md b/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md index 9c20d129..8abf2f0b 100644 --- a/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md +++ b/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md @@ -23,7 +23,7 @@ stories in sync with every frontend component you create, modify, or delete. ## Prerequisites -- Storybook must be installed in the project. If it is not, go to "When Storybook is not installed" below and stop here unless the user opts in. +- Storybook must be installed in the project. If it is not installed and if this skill is not explicitly invoked by the user, silently ignore this skill. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **upgrade** skill to upgrade it before proceeding. From 28e340d9850e97b131f285ff4f4b830b07221f40 Mon Sep 17 00:00:00 2001 From: Julien Huang Date: Fri, 19 Jun 2026 16:45:39 +0200 Subject: [PATCH 2/5] wording --- packages/claude-plugin/skills/stories/SKILL.md | 4 +++- .../codex-plugin/plugins/storybook/skills/stories/SKILL.md | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/claude-plugin/skills/stories/SKILL.md b/packages/claude-plugin/skills/stories/SKILL.md index 051b4e2f..795f74c2 100644 --- a/packages/claude-plugin/skills/stories/SKILL.md +++ b/packages/claude-plugin/skills/stories/SKILL.md @@ -34,7 +34,9 @@ stories in sync with every frontend component you create, modify, or delete. ## Prerequisites -- Storybook must be installed in the project. If it is not installed and if this skill is not explicitly invoked by the user, silently ignore this skill. + - Storybook must be installed in the project. If it is not installed: + - If this skill is not explicitly invoked by the user, silently ignore this skill. + - Otherwise, follow the instructions in "When Storybook is not installed" below. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **storybook-upgrade** skill to upgrade it before proceeding. diff --git a/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md b/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md index 8abf2f0b..8bc00312 100644 --- a/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md +++ b/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md @@ -23,7 +23,9 @@ stories in sync with every frontend component you create, modify, or delete. ## Prerequisites -- Storybook must be installed in the project. If it is not installed and if this skill is not explicitly invoked by the user, silently ignore this skill. + - Storybook must be installed in the project. If it is not installed: + - If this skill is not explicitly invoked by the user, silently ignore this skill. + - Otherwise, follow the instructions in "When Storybook is not installed" below. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **upgrade** skill to upgrade it before proceeding. From 1058f2f57e3b3045d6bf4716da9b39efb23aa53b Mon Sep 17 00:00:00 2001 From: Julien Huang Date: Fri, 19 Jun 2026 17:02:54 +0200 Subject: [PATCH 3/5] remove optout file --- .../claude-plugin/skills/stories/SKILL.md | 44 ++--------------- .../plugins/storybook/skills/stories/SKILL.md | 48 ++----------------- 2 files changed, 8 insertions(+), 84 deletions(-) diff --git a/packages/claude-plugin/skills/stories/SKILL.md b/packages/claude-plugin/skills/stories/SKILL.md index 795f74c2..e8dad2a1 100644 --- a/packages/claude-plugin/skills/stories/SKILL.md +++ b/packages/claude-plugin/skills/stories/SKILL.md @@ -36,51 +36,13 @@ stories in sync with every frontend component you create, modify, or delete. - Storybook must be installed in the project. If it is not installed: - If this skill is not explicitly invoked by the user, silently ignore this skill. - - Otherwise, follow the instructions in "When Storybook is not installed" below. + - Otherwise, ask the user whether they want to set up Storybook and write stories. + - If the user decline, silently skip all story work, finish the component change (if any), and move on. + - If the user accepts, invoke the **storybook-setup** skill to set up Storybook and write stories. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **storybook-upgrade** skill to upgrade it before proceeding. -### When Storybook is not installed - -Installing and configuring Storybook is invasive, so it is the **user's choice**. -Never set it up on your own initiative as a side effect of a component change. - -Before asking the user anything, check whether they have already declined. A -decline can apply at two scopes: - -- **User-level** — the user never wants Storybook set up in any project. -- **Project-level** — the user only declined for this project. - -1. **Look for a previously recorded decline.** If you find one that applies here - (at either scope), the user has ALREADY refused Storybook. Do NOT ask again — - silently skip all story work, finish the component change (if any), and move - on. -2. **If there is no recorded decline**, briefly tell the user the project has no - Storybook and ask whether they want to set it up (and write stories). Offer - three choices: - - **Yes** — set it up for this project. - - **No, not for this project** — decline at the project level. - - **No, and don't ask me again in any project** — decline at the user level. -3. **If the user declines**, remember that decision durably so future - invocations don't re-ask, recording the scope they chose (this project vs. - all projects) and a short paraphrase of their reason. Choose an appropriate - place and format yourself — but do NOT commit it to the project's version - control; if the only durable option lives inside the repo, keep it out of - commits (e.g. via `.gitignore`). Then finish the component change (if any) - without any story work. If the user explicitly asked for story work, STOP and - report that Storybook is required for it. - -4. **If the user opts in**, set Storybook up via the setup skills - (`storybook-init` / `storybook-setup`), then resume this workflow from - Step 1. If you recorded a decline at either scope from a previous "no", clear - it. - -**Gate:** Do NOT install Storybook, scaffold `.storybook/`, add Storybook -dependencies, or invoke the setup skills unless the user has explicitly opted in -this time. A recorded decline at either scope MUST be respected on every later -invocation without re-prompting. - ## Load the rules (before touching any story file) - Run `STORYBOOK_FEATURE_AI_CLI=1 npx storybook ai --help` to get all available subcommands and options. This also gets the latest rules for how to write stories. diff --git a/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md b/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md index 8bc00312..2b54ffc1 100644 --- a/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md +++ b/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md @@ -23,53 +23,15 @@ stories in sync with every frontend component you create, modify, or delete. ## Prerequisites - - Storybook must be installed in the project. If it is not installed: - - If this skill is not explicitly invoked by the user, silently ignore this skill. - - Otherwise, follow the instructions in "When Storybook is not installed" below. +- Storybook must be installed in the project. If it is not installed: + - If this skill is not explicitly invoked by the user, silently ignore this skill. + - Otherwise, ask the user whether they want to set up Storybook and write stories. + - If the user decline, silently skip all story work, finish the component change (if any), and move on. + - If the user accepts, invoke the **setup** skill to set up Storybook and write stories. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **upgrade** skill to upgrade it before proceeding. -### When Storybook is not installed - -Installing and configuring Storybook is invasive, so it is the **user's choice**. -Never set it up on your own initiative as a side effect of a component change. - -Before asking the user anything, check whether they have already declined. A -decline can apply at two scopes: - -- **User-level** — the user never wants Storybook set up in any project. -- **Project-level** — the user only declined for this project. - -1. **Look for a previously recorded decline.** If you find one that applies here - (at either scope), the user has ALREADY refused Storybook. Do NOT ask again — - silently skip all story work, finish the component change (if any), and move - on. -2. **If there is no recorded decline**, briefly tell the user the project has no - Storybook and ask whether they want to set it up (and write stories). Offer - three choices: - - **Yes** — set it up for this project. - - **No, not for this project** — decline at the project level. - - **No, and don't ask me again in any project** — decline at the user level. -3. **If the user declines**, remember that decision durably so future - invocations don't re-ask, recording the scope they chose (this project vs. - all projects) and a short paraphrase of their reason. Choose an appropriate - place and format yourself — but do NOT commit it to the project's version - control; if the only durable option lives inside the repo, keep it out of - commits (e.g. via `.gitignore`). Then finish the component change (if any) - without any story work. If the user explicitly asked for story work, STOP and - report that Storybook is required for it. - -4. **If the user opts in**, set Storybook up via the setup skills - (`init` / `setup`), then resume this workflow from - Step 1. If you recorded a decline at either scope from a previous "no", clear - it. - -**Gate:** Do NOT install Storybook, scaffold `.storybook/`, add Storybook -dependencies, or invoke the setup skills unless the user has explicitly opted in -this time. A recorded decline at either scope MUST be respected on every later -invocation without re-prompting. - ## Load the rules (before touching any story file) - Run `STORYBOOK_FEATURE_AI_CLI=1 npx storybook ai --help` with `require_escalated` to get all available subcommands and options. This also gets the latest rules for how to write stories. From 1dde8f84e0ed71d7597ed45381c564eb0e02bff1 Mon Sep 17 00:00:00 2001 From: Julien Huang Date: Fri, 19 Jun 2026 17:03:29 +0200 Subject: [PATCH 4/5] chore: format --- packages/claude-plugin/skills/stories/SKILL.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/claude-plugin/skills/stories/SKILL.md b/packages/claude-plugin/skills/stories/SKILL.md index e8dad2a1..53aad2b9 100644 --- a/packages/claude-plugin/skills/stories/SKILL.md +++ b/packages/claude-plugin/skills/stories/SKILL.md @@ -34,11 +34,11 @@ stories in sync with every frontend component you create, modify, or delete. ## Prerequisites - - Storybook must be installed in the project. If it is not installed: - - If this skill is not explicitly invoked by the user, silently ignore this skill. - - Otherwise, ask the user whether they want to set up Storybook and write stories. - - If the user decline, silently skip all story work, finish the component change (if any), and move on. - - If the user accepts, invoke the **storybook-setup** skill to set up Storybook and write stories. +- Storybook must be installed in the project. If it is not installed: + - If this skill is not explicitly invoked by the user, silently ignore this skill. + - Otherwise, ask the user whether they want to set up Storybook and write stories. + - If the user decline, silently skip all story work, finish the component change (if any), and move on. + - If the user accepts, invoke the **storybook-setup** skill to set up Storybook and write stories. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **storybook-upgrade** skill to upgrade it before proceeding. From 600e63feae2047db98022c15b0a2e6851dc0e67b Mon Sep 17 00:00:00 2001 From: Julien Huang Date: Fri, 19 Jun 2026 17:25:53 +0200 Subject: [PATCH 5/5] fix: call init skill --- packages/claude-plugin/skills/stories/SKILL.md | 2 +- packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/claude-plugin/skills/stories/SKILL.md b/packages/claude-plugin/skills/stories/SKILL.md index 53aad2b9..4dfd1a27 100644 --- a/packages/claude-plugin/skills/stories/SKILL.md +++ b/packages/claude-plugin/skills/stories/SKILL.md @@ -38,7 +38,7 @@ stories in sync with every frontend component you create, modify, or delete. - If this skill is not explicitly invoked by the user, silently ignore this skill. - Otherwise, ask the user whether they want to set up Storybook and write stories. - If the user decline, silently skip all story work, finish the component change (if any), and move on. - - If the user accepts, invoke the **storybook-setup** skill to set up Storybook and write stories. + - If the user accepts, invoke the **storybook-init** skill to set up Storybook and write stories. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **storybook-upgrade** skill to upgrade it before proceeding. diff --git a/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md b/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md index 2b54ffc1..fdb7a296 100644 --- a/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md +++ b/packages/codex-plugin/plugins/storybook/skills/stories/SKILL.md @@ -27,7 +27,7 @@ stories in sync with every frontend component you create, modify, or delete. - If this skill is not explicitly invoked by the user, silently ignore this skill. - Otherwise, ask the user whether they want to set up Storybook and write stories. - If the user decline, silently skip all story work, finish the component change (if any), and move on. - - If the user accepts, invoke the **setup** skill to set up Storybook and write stories. + - If the user accepts, invoke the **init** skill to set up Storybook and write stories. - Storybook must be a canary version (0.0.0-canary) or at least version 10.5. If an older version is installed, invoke the **upgrade** skill to upgrade it before proceeding.