Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stories not re-rendering when args change in Controls #99

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

leika
Copy link
Contributor

@leika leika commented Apr 5, 2023

Fixes #80

Wrapped rendered Story Component and reset context Information on change to rebuild/rerender Component when Args changed

Small Fix that would rerender Components after args changed.

…nge to rebuild/rerender Component when Args changed
… context entries to store args and global context during rendertime
@leika
Copy link
Contributor Author

leika commented Apr 5, 2023

Also works with latest sveltekit releases.

@JReinhold JReinhold self-assigned this Apr 14, 2023
@JReinhold JReinhold added bug Something isn't working patch Increment the patch version when merged labels Apr 14, 2023
Copy link
Collaborator

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a great contribution!! 🎉

@JReinhold JReinhold changed the title Wrapped rendered Story Component and reset context Information on change to rebuild/rerender Component when Args changed Fix stories not re-rendering when args change in Controls Apr 21, 2023
@JReinhold JReinhold merged commit 9498e50 into storybookjs:main Apr 21, 2023
@shilman
Copy link
Member

shilman commented Apr 21, 2023

🚀 PR was released in v3.0.2 🚀

@shilman shilman added the released This issue/pull request has been released. label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Storybook 7 Controls doesn't change component within iframe unless manually trigger refresh
4 participants