Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Support for portable stories and experimental vitest-addon #213

Closed
Tracked by #29531
bhvngt opened this issue Sep 19, 2024 · 7 comments · Fixed by storybookjs/storybook#30105
Closed
Tracked by #29531
Assignees
Labels
enhancement New feature or request next Related to the next version

Comments

@bhvngt
Copy link

bhvngt commented Sep 19, 2024

As storybook 8.3 is out with experimental support for running portable stories with vitest.

This is a feature request for supporting svelte-native csf with vitest-plugin. This will also enable this plugin to support exportable portable stories.

@xeho91
Copy link
Collaborator

xeho91 commented Nov 5, 2024

@JReinhold

Do we want to try to solve this case before the major release?

You once asked me if it was necessary to provide the enforce: "post" option for Vite transform plugin.
I'm exploring this quickly, and removing this option doesn't break anything. I've tested on dev and build modes.

Is that the only thing that was the blocker, or is there anything else?

@JReinhold
Copy link
Collaborator

@xeho91 if you can remove the enforce: "post" that would be great, as we know that is a known blocker. There is also work to be done in core to truly fix this, but that will be easier done when the enforce ment is gone.

@xeho91
Copy link
Collaborator

xeho91 commented Dec 7, 2024

@xeho91 if you can remove the enforce: "post" that would be great, as we know that is a known blocker. There is also work to be done in core to truly fix this, but that will be easier done when the enforce ment is gone.

#241

@bhvngt
Copy link
Author

bhvngt commented Jan 14, 2025

Thanks @JReinhold for closing this issue. Does this mean that latest storybook build v8.5.0-beta.10 supports portable stories when used with vitest-addon?

@JReinhold
Copy link
Collaborator

Yup @bhvngt :)

It's all experimental still, so please try it out and report any issues you find!

@JReinhold
Copy link
Collaborator

@bhvngt you might want to know about the two limitations I've discovered:

#261
#262

@bhvngt
Copy link
Author

bhvngt commented Jan 15, 2025

Thanks @JReinhold for the heads up. I will start doing some testing on my experimental project in the coming week. Will file issues as I discover them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next Related to the next version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants