Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install beta v2 after installing Storybook v7-beta63 #185

Closed
11 tasks
arianaamx-motorway opened this issue Mar 8, 2023 · 6 comments
Closed
11 tasks
Labels
category: bug Something isn't working

Comments

@arianaamx-motorway
Copy link

arianaamx-motorway commented Mar 8, 2023

Affected design types

  • figma
  • figspec
  • link
  • image
  • iframe

Describe the bug

Updated the Storybook to v7.beta63, and now I can't install storybook-addon-designs betav2.
Using: npm install --save-dev storybook-addon-designs@beta

Error message:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: -----
npm ERR! Found: @storybook/[email protected]
npm ERR! node_modules/@storybook/addon-docs
npm ERR!   @storybook/addon-docs@"7.0.0-beta.63" from @storybook/[email protected]
npm ERR!   node_modules/@storybook/addon-essentials
npm ERR!     dev @storybook/addon-essentials@"^7.0.0-beta.63" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! dev storybook-addon-designs@"7.0.0-beta.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @storybook/[email protected]
npm ERR! node_modules/@storybook/addon-docs
npm ERR!   peer @storybook/addon-docs@"^6.4.0 || ^7.0.0" from [email protected]
npm ERR!   node_modules/storybook-addon-designs
npm ERR!     dev storybook-addon-designs@"7.0.0-beta.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Installed @storybook/addons directly, still getting the error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: -----
npm ERR! Found: @storybook/[email protected]
npm ERR! node_modules/@storybook/addons
npm ERR!   dev @storybook/addons@"^7.0.0-beta.63" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @storybook/addons@"^6.4.0 || ^7.0.0" from [email protected]
npm ERR! node_modules/storybook-addon-designs
npm ERR!   dev storybook-addon-designs@"7.0.0-beta.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Package.json

"devDependencies": {
    "@storybook/addon-a11y": "^7.0.0-beta.63",
    "@storybook/addon-actions": "^7.0.0-beta.63",
    "@storybook/addon-essentials": "^7.0.0-beta.63",
    "@storybook/addon-links": "^7.0.0-beta.63",
    "@storybook/addon-storysource": "^7.0.0-beta.63",
    "@storybook/react": "^7.0.0-beta.63",
    "@storybook/react-vite": "^7.0.0-beta.63",
    "storybook": "^7.0.0-beta.63",
    "storybook-dark-mode": "^1.1.0",
}

How to reproduce the bug?

  1. npm install -D storybook@next @storybook/addon-essentials
  2. npm install --save-dev storybook-addon-designs@beta

Expected behaviour

There shouldn't be any errors when trying to install the addon.

Environment

  • Chrome / Chromium / Chromium based browsers
  • Firefox
  • macOS Safari
  • iOS Safari
  • Samsung Internet
  • Other

Affected versions

Trying to upgrade to beta v2, until then 6.3.1

Storybook versions

7.0.0-beta.63

@arianaamx-motorway arianaamx-motorway added the category: bug Something isn't working label Mar 8, 2023
@toyopilgrim
Copy link

toyopilgrim commented Mar 12, 2023

I've encountered the same error on yarn check. It seems not specific to 7.0.0-beta.63.
I confirmed that the errors on 7.0.0-beta.46 and 7.0.0-rc.1. By using [email protected], I could avoid the error.

yarn check

error "storybook-addon-designs#@storybook/addon-docs@^6.4.0 || ^7.0.0" doesn't satisfy found match of "@storybook/[email protected]"
[8](https://github.com/linkx-dev/aml-poc-frontend/actions/runs/4395011815/jobs/7696469312#step:6:9)
error "storybook-addon-designs#@storybook/components@^6.4.0 || ^7.0.0" doesn't satisfy found match of "@storybook/[email protected]"
[9](https://github.com/linkx-dev/aml-poc-frontend/actions/runs/4395011815/jobs/7696469312#step:6:10)
error "storybook-addon-designs#@storybook/theming@^6.4.0 || ^7.0.0" doesn't satisfy found match of "@storybook/[email protected]"

@itzikd15
Copy link

i got the same error as well, downgrading to:
"storybook-addon-designs": "6.3.1",
solved the issue for me as well, thanks!

@darroshi
Copy link

darroshi commented Mar 13, 2023

@itzikd15 did you use
"storybook-addon-designs": "6.3.1",
with storybook 7.0.0-rc.1 ?
I tried, and the Design tab doesn't appear.

@itzikd15
Copy link

i noticed i don't have it either. my solution for now is to do "npm install --legacy-peer-deps" until the fix it.

@itzikd15
Copy link

itzikd15 commented Mar 30, 2023

currently on Storybook 7.0.0-rc.5 and still it doesn't work.
is it possible to change in this file:
https://github.com/storybookjs/addon-designs/blob/master/packages/storybook-addon-designs/package.json

at the peerDependencies part:

"peerDependencies": {
    "@storybook/addon-docs": "^6.4.0 || ^7.0.0",
    "@storybook/addons": "^6.4.0 || ^7.0.0",
    "@storybook/api": "^6.4.0 || ^7.0.0",
    "@storybook/components": "^6.4.0 || ^7.0.0",
    "@storybook/theming": "^6.4.0 || ^7.0.0",
    "react": "^16.8.0 || ^17.0.0 || ^18.0.0",
    "react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0"
  },

the option to support version 7 beta and alpha for the @storybook dependencies
@pocka

i created a pull request
#189

@pocka
Copy link
Collaborator

pocka commented Jun 10, 2023

SB7 is now stable. For compatibility issues, please refer to #191 (SB7 support is in-progress #192).

@pocka pocka closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants