Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty of adding other query methods available in scipy KDTree #41

Open
djhoese opened this issue Dec 20, 2018 · 3 comments
Open

Difficulty of adding other query methods available in scipy KDTree #41

djhoese opened this issue Dec 20, 2018 · 3 comments

Comments

@djhoese
Copy link
Collaborator

djhoese commented Dec 20, 2018

Are there any plans to add the other query methods available in scipy's KDTree implementation? Is it possible with pykdtree's method? How difficult would it be and what kind of headaches could you imagine?

See the bottom of this page for a list of the query methods: https://docs.scipy.org/doc/scipy/reference/generated/scipy.spatial.cKDTree.html

@storpipfugl
Copy link
Owner

It wasn't something I had considered. Would it make an important difference to some known use cases or is it more nice to have compatibility?
Looking at the scipy code there's some C++ code to make sense of but nothing complex just time consuming. There would also be a benchmarking effort to make sure scipy is defeated properly. The cKDTree implementations are not parallelized so that would have to be added (can be trivial or really difficult depending on implementation details)

@djhoese
Copy link
Collaborator Author

djhoese commented Jan 22, 2019

Good points. This was for use cases that @leouieda and I were discussing when he made a PR for his "verde" library that basically meant the user had to pick if they wanted a scipy or pykdtree KDTree based on what methods they may call in the future.

@leouieda
Copy link

Hi @storpipfugl, the PR that @djhoese mentioned is fatiando/verde#165. I mostly need query_ball_point as well but I could imagine needing some other methods in the future. I can run some benchmarks on my code if you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants