all: fix linters

Change-Id: I6e00020b02132c4af4bbf55115da13074230c826

Author: egonelbre

errs2/ignore.go

@@ -14,7 +14,7 @@ import (
 // IsCanceled returns true, when the error is a cancellation.
 func IsCanceled(err error) bool {
 	return errs.IsFunc(err, func(err error) bool {
-		return err == context.Canceled || //nolint: errorlint, goerr113
+		return err == context.Canceled || //nolint:errorlint, goerr113
 			rpcstatus.Code(err) == rpcstatus.Canceled
 	})
 }

ranger/httpranger/http.go

@@ -57,7 +57,7 @@ func HTTPRanger(ctx context.Context, url string) (_ ranger.Ranger, err error) {
 // HTTPRangerSize creates an HTTPRanger with known size.
 // Use it if you know the content size. This will safe the extra HEAD request
 // for retrieving the content size.
-func HTTPRangerSize(url string, size int64) ranger.Ranger { // nolint:golint,revive
+func HTTPRangerSize(url string, size int64) ranger.Ranger { //nolint:golint,revive
 	return &httpRanger{
 		URL:  url,
 		size: size,

rpc/rpccache/cache_test.go

@@ -416,7 +416,7 @@ func runBenchmarkFilterSlice(b *testing.B, n int) {
 	for i := 0; i < b.N; i++ {
 		ent := ents[0]
 		ents = filterEntry(ents, ent)
-		ents = append(ents, ent) //nolint: makezero // the test removes from slice and adds it back
+		ents = append(ents, ent) //nolint:makezero // the test removes from slice and adds it back
 	}
 }
 

socket/dscp.go

@@ -5,13 +5,13 @@ package socket
 
 // A DSCP is a Differentiated Services Code Point.
 //
-// nolint: unused
+//nolint:unused
 type dscp byte
 
 // See https://tools.ietf.org/html/rfc4594#section-2.3 for the definitions
 // of the below Differentiated Services Code Points.
 //
-// nolint: deadcode,varcheck,unused
+//nolint:deadcode,varcheck,unused
 const (
 	dscpDF   dscp = 0
 	dscpCS6  dscp = 0b110000

storj/node_test.go

@@ -146,13 +146,13 @@ func TestNodeID_String_Version(t *testing.T) {
 
 func TestNodeID_Compare(t *testing.T) {
 	var a storj.NodeID
-	require.Equal(t, 0, a.Compare(a)) //nolint: gocritic
+	require.Equal(t, 0, a.Compare(a)) //nolint:gocritic
 
 	for k := 0; k < len(storj.NodeID{}); k++ {
 		var a, b storj.NodeID
 		a[k], b[k] = 1, 2
-		require.Equal(t, 0, a.Compare(a)) //nolint: gocritic
-		require.Equal(t, 0, b.Compare(b)) //nolint: gocritic
+		require.Equal(t, 0, a.Compare(a)) //nolint:gocritic
+		require.Equal(t, 0, b.Compare(b)) //nolint:gocritic
 		require.Equal(t, -1, a.Compare(b))
 		require.Equal(t, 1, b.Compare(a))
 	}

sync2/cooldown.go

@@ -19,7 +19,7 @@ import (
 //
 // Start or Run (only one of them, not both) must be only called once.
 type Cooldown struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	stopsent int32
 	runexec  int32

sync2/cycle.go

@@ -20,7 +20,7 @@ import (
 //
 // Start or Run (only one of them, not both) must be only called once.
 type Cycle struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	stopsent int32
 	runexec  int32

sync2/fence.go

@@ -10,7 +10,7 @@ import (
 
 // Fence allows to wait for something to happen.
 type Fence struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	setup   sync.Once
 	release sync.Once

sync2/limiter.go

@@ -13,7 +13,7 @@ import (
 // After calling Wait or Close, no new goroutines are allowed
 // to start.
 type Limiter struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	limit  chan struct{}
 	close  sync.Once

sync2/nocopy.go

@@ -8,7 +8,7 @@ package sync2
 //
 // See https://golang.org/issues/8005#issuecomment-190753527.
 //
-// Currently users of noCopy must use "// nolint: structcheck",
+// Currently users of noCopy must use "//nolint:structcheck",
 // because golint-ci does not handle this correctly.
 type noCopy struct{}
 

sync2/readcache.go

@@ -14,7 +14,7 @@ import (
 // ReadCache implements refreshing of state based on a refresh timeout,
 // but also allows for stale reads up to a certain duration.
 type ReadCache struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	started Fence
 	ctx     context.Context

sync2/semaphore.go

@@ -11,7 +11,7 @@ import (
 
 // Semaphore implements a closable semaphore.
 type Semaphore struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	ctx   context.Context
 	close func()

sync2/success_threshold.go

@@ -16,7 +16,7 @@ import (
 // It notifies the caller when reached a specific successful threshold without
 // interrupting the remaining tasks.
 type SuccessThreshold struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	toSucceed int64
 	pending   int64

sync2/tee.go

@@ -91,7 +91,7 @@ func NewTeeInmemory(readers int, blockSize int64) ([]PipeReader, PipeWriter, err
 
 // tee synchronizes access to a shared buffer with one writer and multiple readers.
 type tee struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	open *int64
 

sync2/throttle.go

@@ -9,7 +9,7 @@ import (
 
 // Throttle implements two-sided throttling, between a consumer and producer.
 type Throttle struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	mu       sync.Mutex
 	consumer sync.Cond

sync2/workgroup.go

@@ -9,7 +9,7 @@ import (
 
 // WorkGroup implements waitable and closable group of workers.
 type WorkGroup struct {
-	noCopy noCopy // nolint: structcheck
+	noCopy noCopy //nolint:structcheck
 
 	mu   sync.Mutex
 	cond sync.Cond

uuid/uuid_test.go

@@ -146,13 +146,13 @@ func TestMarshal(t *testing.T) {
 
 func TestCompare(t *testing.T) {
 	var a uuid.UUID
-	require.Equal(t, 0, a.Compare(a)) //nolint: gocritic
+	require.Equal(t, 0, a.Compare(a)) //nolint:gocritic
 
 	for k := 0; k < len(uuid.UUID{}); k++ {
 		var a, b uuid.UUID
 		a[k], b[k] = 1, 2
-		require.Equal(t, 0, a.Compare(a)) //nolint: gocritic
-		require.Equal(t, 0, b.Compare(b)) //nolint: gocritic
+		require.Equal(t, 0, a.Compare(a)) //nolint:gocritic
+		require.Equal(t, 0, b.Compare(b)) //nolint:gocritic
 		require.Equal(t, -1, a.Compare(b))
 		require.Equal(t, 1, b.Compare(a))
 	}