Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major release items #687

Open
brodycj opened this issue May 9, 2017 · 3 comments
Open

Major release items #687

brodycj opened this issue May 9, 2017 · 3 comments

Comments

@brodycj
Copy link
Contributor

brodycj commented May 9, 2017

General

IMPORANT NOTICE: FEATURES SCHEDULED FOR REMOVAL FROM NEXT MAJOR RELEASE:

  • Deprecated "standard" transaction API ref: Removing Web SQL transaction calls from next major release #720 (will continue to be supported by other plugin versions such as cordova-sqlite-ext and cordova-sqlite-evcore-extbuild-free)
  • Windows platform support (also will continue to be supported by other plugin versions such as cordova-sqlite-ext and cordova-sqlite-evcore-extbuild-free)

NOTE: As discussed here and in #720 it would be problematic to remove the deprecated "standard" transaction API and Windows platform support. I hope to deliver a new express plugin version using internal sqlite3 libraries on Android/iOS/macOS, with Windows platform support, external sqlite3 dependencies, and likely "standard" transaction API removed (#740) within the next couple months or so.

Other general items:

Documentation

Should be documented in #685 (upcoming minor release items):

Possible carryover from #685:

Major release items:

Testing

Possible carryover from #685 (upcoming minor release items):

Fixes & features

Should be fixed in #685 (upcoming minor release items):

Possible carryover from #685:

Major release items:

ADDED ITEMS:

ADDED ITEMS FOR THIS PLUGIN VERSION ONLY:

  • Use built-in sqlite library on Android/iOS/macOS (planning to do this in a new express plugin version, at some point in the future)
  • Drop support for close and delete calls in this plugin version (support for close and delete calls will be maintained in other versions such as cordova-sqlite-ext and cordova-sqlite-evcore-extbuild-free) (close & delete calls are needed to support selfTest)
  • Drop iOS database location option (again this would continue to be supported in versions such as cordova-sqlite-ext and cordova-sqlite-evcore-extbuild-free)

ADDED FOR OTHER PLUGIN VERSIONS:

OTHER ADDED ITEMS FOR CONSIDERATION:

  • database.dispose() to dispose a single database handle, close database once all handle objects have been disposed
  • Drop Apache 2.0 license option for Android and Windows platforms, MIT only for all platforms
  • SQLITE_LOCKING_STYLE=1 seems to be automatically defined for Apple Darwin platforms (iOS/macOS), see if this would also work on Android/Windows
  • result set with Array [] access but must keep item() function for compatibility ref: Query should return an array [...] #755

GENERAL ADDED DOCUMENTATION ITEM: MAJOR DOCUMENTATION CLEANUP NEEDED ref: storesafe/cordova-sqlite-storage-help#33 & #596 (comment)

TEST and DOCUMENT maximum record size ref: #474, #766

Timeline

At least 2-3 months, possibly longer due to existing backlog and other priority items. Hopefully in January or February 2018. GENERAL COMMENT: Priority goes to paid users. For more information please contact: [email protected]

@mobidev111
Copy link

@brodybits Whats the reason to drop Windows platform support? Moving this out of this mainstream repo will greatly diminish this lib's usefulness as true cross-platform database. The windows version is working fine - so in general no need to change this (now)?

@brodycj
Copy link
Contributor Author

brodycj commented Jan 16, 2018

Moving this out of this mainstream repo will greatly diminish this lib's usefulness as true cross-platform database.

Thanks @mobidev111 for the feedback. I think I have to agree with you, despite the pain of maintaining support (additional system needed, dealing with VS issues, etc.) I also want to ensure that the common plugin JavaScript will work on all supported platforms, including Windows, without having to test on multiple plugin versions before releasing. So Windows support will stay in this plugin version, new express version will be delivered with Windows support and external sqlite3 library dependencies dropped when I get a chance (#740).

@brodycj
Copy link
Contributor Author

brodycj commented Jan 17, 2018

An additional item is that I may merge this plugin version together with cordova-sqlite-ext, as the basis for all other current plugin versions. This should simplify maintenance and support for most plugin users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants