fix: respect the required parameter in the body #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [lodash.template](https://github.com/lodash/lodash) from 4.4.0 to 4.5.0. **This update includes security fixes.** - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.4.0...4.5.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.13. **This update includes security fixes.** - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.13) Signed-off-by: dependabot-preview[bot] <[email protected]>
XVincentX
changed the title
XVincentX
force-pushed
the
feat/body-validation-required
branch
from
44df14b
to
a071b25
Compare
XVincentX
force-pushed
the
feat/body-validation-required
branch
from
7419c0d
to
62efb4d
Compare
XVincentX
commented
Jul 12, 2019
| @@ -2,7 +2,7 @@ | |||
| "swagger": "2.0", | |||
| "paths": { | |||
| "/pet": { | |||
| "get": { | |||
| "post": { | |||
There was a problem hiding this comment.
In case you're wondering, get should not really have body parameters.
XVincentX
commented
Jul 12, 2019
| this.bodyValidator | ||
| .validate(body, (request && request.body && request.body.contents) || [], mediaType) | ||
| .forEach(validationResult => results.push(validationResult)); | ||
| if (request && request.body) { |
There was a problem hiding this comment.
This will be way easier to read when we'll introduce Option<T> in fp-ts.
philsturgeon
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #419
Requires #446