Make the validation process sync #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
approved these changes
Jul 6, 2019
|
@philsturgeon Get ready for another monster soon :) |
|
This is good work, but I think we should focus on writing test harness files so we can be more confident in e2e continuing to work through these big changes. Now is a time for stabilisation not clearing tech debt. :)
…--
Phil Sturgeon
@philsturgeon
On Jul 6, 2019, at 11:11, Vincenzo Chianese ***@***.***> wrote:
Merged #400 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've checked the code multiple times and there is really no reason the validation process should be marked as async — it's indeed not.
This PR removes any doubts about it so it's going to be easier to reason about it