Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Pages #393

Merged
merged 15 commits into from
Jul 5, 2019
Merged

Documentation Pages #393

merged 15 commits into from
Jul 5, 2019

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Jul 3, 2019

  • Adds Example generation strategy document
  • Moves stuff out from the main Readme into separate docs pages
  • Specify a little bit more what's going on with Validation response generation

@XVincentX XVincentX force-pushed the docs/dosc branch 3 times, most recently from eef9716 to acc48c0 Compare July 4, 2019 05:12
docs/examples.md Outdated Show resolved Hide resolved
docs/examples.md Outdated Show resolved Hide resolved
docs/examples.md Outdated Show resolved Hide resolved
docs/examples.md Outdated Show resolved Hide resolved
docs/examples.md Show resolved Hide resolved
@XVincentX
Copy link
Contributor Author

Great catches @philsturgeon — I've pushed some changes and I'll move forward to responses docs

docs/examples.md Outdated Show resolved Hide resolved
docs/examples.md Outdated Show resolved Hide resolved
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome so far!

Could we maybe move the CLI stuff from the main README into a new CLI docs file?

I know we have README in packages/cli/ etc but they are instructions for contributors who are looking, we should move end user docs to this top level docs folder so they're all displayed on our new hosted docs.

@marbemac had a really cool idea he started on for Spectral, which is to have ## Examples and then bullet point lists of common things we think users might want to do.

  • Get Prism to show different named examples
  • Create dynamic examples
  • Show validation errors for garbage requests

That sort of thing. We highlight cool stuff and link directly to the docs/foo.md and the proper #header-id so folks can read about it, without making the README huge.

@XVincentX XVincentX marked this pull request as ready for review July 5, 2019 08:02
@XVincentX
Copy link
Contributor Author

had a really cool idea he started on for Spectral, which is to have ## Examples and then bullet point lists of common things we think users might want to do.

It seems to me kind of a table of content of the docs directory, right?

@philsturgeon
Copy link
Contributor

@XVincentX not so much table of contents, it's just some examples. Much like we have them in the readme at the moment, this is a link to somewhere else. Our documentation section will take care of standard navigation stuff like a ToC.

docs/validation.md Outdated Show resolved Hide resolved
@XVincentX XVincentX merged commit c62f377 into master Jul 5, 2019
@XVincentX XVincentX deleted the docs/dosc branch July 5, 2019 08:32
@XVincentX XVincentX mentioned this pull request Jul 8, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants