Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/so-133/dfd #386

Merged
merged 8 commits into from
Jun 28, 2019
Merged

Docs/so-133/dfd #386

merged 8 commits into from
Jun 28, 2019

Conversation

chris-miaskowski
Copy link
Contributor

moved DFD to main readme

@marbemac
Copy link
Contributor

This is cool! Couple of suggestions:

  • Remove date from image
  • Change v1.0.0 to the prism major or minor version? Otherwise kind of confusing. E.g. v3. Or remove version altogether
  • Add a link below it for somebody to edit it? E.g. if there is an inconsistency now or in the future that somebody notices, how are they going to put in a PR to update it?

@philsturgeon philsturgeon merged commit cb43089 into master Jun 28, 2019
@philsturgeon philsturgeon deleted the docs/so-133/dfd branch June 28, 2019 15:15
@marbemac
Copy link
Contributor

Orr not lol. At least add a link somewhere so that folks can edit that diagram? Re-creating it would be a bummer.

@chris-miaskowski
Copy link
Contributor Author

Orr not lol. At least add a link somewhere so that folks can edit that diagram? Re-creating it would be a bummer.

:D I think Phil didn't notice your comments, I created another PR with the link to original

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsturgeon philsturgeon philsturgeon approved these changes

@XVincentX XVincentX Awaiting requested review from XVincentX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris-miaskowski @marbemac @philsturgeon