-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly derive a valid JSON Schema from an OAS parameter #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @XVincentX, great job so far! Left you a bunch of smaller comments.
My last point is that I couldn't find a test case for the originally reported issue (the header param).
Maybe we could take the exact spec provided in the original issue report and use it to feed the test?
@philsturgeon @chris-miaskowski Please have another look. |
Can you elaborate more? What is the test that's missing? The original issue was on the camel case of the headers, which now have a test. |
@XVincentX what I meant about the tests, is that we should probably add some cases to the functional tests for changes as we go. packages/http/src/mocker/tests/functional.spec.ts didnt seem to get any love? |
@philsturgeon That test file is testing the mocker, which is after the validation step. I understand what you mean though, I'll find the relevant file and add the stuff you asked for. |
This PR updates Graphite in Prism to use the latest version which includes the JSON Schema normalisation features.
P.S: There are some other weird things happening in the deserialisation that I want to lookup and fix, but not here, not now.
Closes #324