Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade jsrp to 9.2.4 to allow basic auth #2279

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

daniel-white
Copy link
Member

Addresses #2270

Summary

http-basic auth via the url is blocked by fetch in node 18+. this upgrade of jsrp supports converting that to an auth header as appropriate.

Checklist

  • The basics
    • I tested these changes manually in my local or dev environment
  • Tests
    • Added or updated
    • N/A
  • Event Tracking
    • I added event tracking and followed the event tracking guidelines
    • N/A
  • Error Reporting
    • I reported errors and followed the error reporting guidelines
    • N/A

@daniel-white daniel-white requested a review from a team as a code owner May 4, 2023 18:34
@daniel-white daniel-white requested review from chohmann and removed request for a team May 4, 2023 18:34
Copy link
Contributor

@chohmann chohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming all the testing has been done over in json schema ref parser.

@daniel-white
Copy link
Member Author

@chohmann as well as it can yes. i had to fix something over there after some oddities came up when running it w/ prism

@daniel-white daniel-white merged commit 2148a2b into master May 4, 2023
4 checks passed
@daniel-white daniel-white deleted the fix/fetch-auth branch May 4, 2023 18:52
This was referenced Apr 29, 2024
This was referenced Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants