fix: schema faker fix (#195)

* fix: SL-2036 deep clone schema for json-schema-faker * test: SL-2036 added test
stoplightio · Mar 14, 2019 · 5889cc7 · 5889cc7
1 parent 2462ce6
commit 5889cc7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/packages/http/src/mocker/generator/JSONSchemaExampleGenerator.ts b/packages/http/src/mocker/generator/JSONSchemaExampleGenerator.ts
@@ -5,7 +5,7 @@ import { IExampleGenerator } from './IExampleGenerator';
 
 export class JSONSchemaExampleGenerator implements IExampleGenerator<any> {
   public async generate(schema: any, mediaType: string): Promise<string> {
-    const example = await jsf.resolve(schema);
+    const example = await jsf.resolve(JSON.parse(JSON.stringify(schema)));
     return this.transform(mediaType, example);
   }
 

diff --git a/packages/http/src/mocker/generator/__tests__/JSONSchemaExampleGenerator.spec.ts b/packages/http/src/mocker/generator/__tests__/JSONSchemaExampleGenerator.spec.ts
@@ -28,9 +28,25 @@ describe('JSONSchemaExampleGenerator', () => {
     });
 
     it('fails when media type is unknown', async () => {
-      expect(
+      return expect(
         jsonSchemaExampleGenerator.generate({}, 'non-existing/media-type')
       ).rejects.toThrowErrorMatchingSnapshot();
     });
+
+    it('operates on sealed schema objects', async () => {
+      const schema = {
+        type: 'object',
+        properties: {
+          name: { type: 'string' },
+        },
+        required: ['name'],
+      };
+
+      Object.defineProperty(schema.properties, 'name', { writable: false });
+
+      return expect(
+        jsonSchemaExampleGenerator.generate(schema, 'application/json')
+      ).resolves.toBeTruthy();
+    });
   });
 });