Skip to content

Conversation

SB-harshitajadhav
Copy link
Contributor

@SB-harshitajadhav SB-harshitajadhav commented Nov 19, 2024

Motivation and Context

STOP-231

Description

Previously range was getting displayed without being defined in the schema for int64.

How Has This Been Tested?

Tested locally by doing yalc in Platform internal.

Screenshot(s)/recordings(s)

Before
image

After
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Copy link

@prafullaAtSB prafullaAtSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go ahead with these changes.
Add more explanation of root cause and area where it is failing in the documentation.

Copy link

@bhaskarsontakke bhaskarsontakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned by Prafulla, please provide the detail why we have removed int64 min/max calculation. changes looks ok to me

Copy link
Contributor

@SB-pradeep-bande SB-pradeep-bande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SB-harshitajadhav SB-harshitajadhav merged commit 9b6b1e4 into master Nov 22, 2024
1 check passed
@SB-harshitajadhav SB-harshitajadhav deleted the STOP231 branch November 22, 2024 09:31
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants