-
Notifications
You must be signed in to change notification settings - Fork 45
fix: Don't display int64 range in docs #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go ahead with these changes.
Add more explanation of root cause and area where it is failing in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned by Prafulla, please provide the detail why we have removed int64 min/max calculation. changes looks ok to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
🎉 This PR is included in version 4.16.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Motivation and Context
STOP-231
Description
Previously range was getting displayed without being defined in the schema for int64.
How Has This Been Tested?
Tested locally by doing yalc in Platform internal.
Screenshot(s)/recordings(s)
Before

After

Types of changes
Checklist