fix: <binary> is not displaying in the docs #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-white
reviewed
May 8, 2024
src/utils/getApplicableFormats.ts
Outdated
| export function getApplicableFormats(schemaNode: RegularNode): [type: SchemaNodeKind, format: string] | null { | ||
| // Format is handled for contentMediaType type i.e. binary format | ||
| if (schemaNode.types !== null && schemaNode.fragment['contentMediaType'] === 'application/octet-stream') { | ||
| for (const type of schemaNode.types) { |
There was a problem hiding this comment.
why a loop here if its just going to return?
There was a problem hiding this comment.
Hello @daniel-white , I have updated the getApplicableFormat.ts , please review it once.
EdVinyard
reviewed
May 9, 2024
daniel-white
reviewed
May 9, 2024
EdVinyard
approved these changes
May 10, 2024
There was a problem hiding this comment.
Per our discussion, @SB-harshitajadhav will put this back in to the way she originally wrote it. Otherwise, it looks great!
SB-harshitajadhav
deleted the
STOP-464-binary-is-not-displaying-in-the-docs
branch
|
🎉 This PR is included in version 4.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
STOP-464
Description
Format is handled for contentMediaType type i.e. binary format
How Has This Been Tested?
Tested in local environment.
Screenshot(s)/recordings(s)
Types of changes
Checklist