Skip to content

Conversation

brendarearden
Copy link
Contributor

@brendarearden brendarearden commented Dec 14, 2023

Motivation and Context

stoplightio/elements#2419

A reference within an allOf that had description or summary ref siblings were getting overwritten by description and summary from the referenced object.

Description

Bump json-schema-tree version that has fix that does not allow reference description and summary to overwrite the ref sibling's values
Added ref resolver for storybook so that the references are actually resolved for storybook

How Has This Been Tested?

Added storybook that shows the allOf reference example

Screenshot(s)/recordings(s)

Before version bump:
Screenshot 2023-12-14 at 12 37 41 PM

After version bump:
Screenshot 2023-12-14 at 12 35 38 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@brendarearden brendarearden requested review from a team and kaylachun and removed request for a team December 14, 2023 20:12
@brendarearden brendarearden merged commit ea0ac6f into master Dec 14, 2023
@brendarearden brendarearden deleted the chore/bump-version branch December 14, 2023 21:35
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 4.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants